Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ruby/setup-ruby to simplify CI #335

Merged
merged 2 commits into from
Feb 6, 2020
Merged

Use ruby/setup-ruby to simplify CI #335

merged 2 commits into from
Feb 6, 2020

Conversation

eregon
Copy link
Member

@eregon eregon commented Feb 6, 2020

  • ruby/setup-ruby supports more versions than actions/setup-ruby.
  • ruby/setup-ruby is faster to install Rubies than RVM (and much easier in GitHub Actions).

cc @hsbt @ioquatix

@eregon
Copy link
Member Author

eregon commented Feb 6, 2020

This currently drops jruby-head, do we want to keep it? I can try to support it in https://github.com/ruby/setup-ruby.

@eregon
Copy link
Member Author

eregon commented Feb 6, 2020

ruby/setup-ruby also allows testing basically any version on any platform.
Should we test 2.3, 2.2, jruby, truffleruby, ruby-head on macOS and Windows too?

@eregon eregon requested a review from hsbt February 6, 2020 14:52
@hsbt
Copy link
Member

hsbt commented Feb 6, 2020

Thanks! I definitely prefer this.

@hsbt hsbt merged commit 1111437 into ruby:master Feb 6, 2020
@ioquatix
Copy link
Member

ioquatix commented Feb 6, 2020

Nice work!

@eregon eregon deleted the use-setup-ruby branch February 7, 2020 00:47
@eregon eregon mentioned this pull request Feb 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsbt hsbt hsbt approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eregon @hsbt @ioquatix