Do not attempt to read binary files

While RDoc had binary checks, it did not apply them at the appropriate
location.  Now binary checking is performed before attempting to convert
a document to UTF-8 to avoid the warning.

Fixes #189
Fixes #190
Fixes #195

History.rdoc

@@ -15,6 +15,8 @@
   * RDoc::Servlet no longer ignores extra directories from -d.  Pull request
     #173 by Thomas Leitner
   * Fixed `rdoc --ri-site`.  Bug #193 by Michal Papis.
+  * RDoc no longer attempts to parse binary files.  Bug #189 by postmodern,
+    Bug #190 by Christoffer Lervåg, Bug #195 by Aaron Patterson
 
 === 4.0.0 / 2013-02-24
 

lib/rdoc/rdoc.rb

@@ -342,6 +342,8 @@ def parse_file filename
 
     @stats.add_file filename
 
+    return if RDoc::Parser.binary? filename
+
     content = RDoc::Encoding.read_file filename, encoding
 
     return unless content

test/test_rdoc_rdoc.rb

@@ -162,6 +162,24 @@ def test_parse_file
     end
   end
 
+  def test_parse_file_binary
+    @rdoc.store = RDoc::Store.new
+
+    root       = File.dirname __FILE__
+    binary_dat = File.expand_path 'binary.dat', root
+
+    @rdoc.options.root = Pathname root
+
+    out, err = capture_io do
+      Dir.chdir root do
+        assert_nil @rdoc.parse_file 'binary.dat'
+      end
+    end
+
+    assert_empty out
+    assert_empty err
+  end
+
   def test_parse_file_page_dir
     @rdoc.store = RDoc::Store.new