Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In v6.8.1, C extension objects "Ancestors" list shows C symbol name instead of class name #1205

Open
flavorjones opened this issue Nov 11, 2024 · 0 comments · May be fixed by #1217
Open

In v6.8.1, C extension objects "Ancestors" list shows C symbol name instead of class name #1205

flavorjones opened this issue Nov 11, 2024 · 0 comments · May be fixed by #1217
Labels
bug

Comments

@flavorjones
Copy link
Contributor

Hi! I love the ancestors list, but I found an edge case with how it handles C extensions.

Take a look at the sidebar at https://nokogiri.org/rdoc/Nokogiri/HTML4/Document.html which was generated from 50dda13:

image

The actual ancestors list is:

Nokogiri::XML::Document
+- Nokogiri::XML::Node
   +- Object
      +- BasicObject

but instead it's showing cNokogiriXmlNode which is the C symbol that references the Nokogiri::XML::Node class (from ext/nokogiri/xml_node.c).

I haven't had time to dig into this yet, but wanted to raise an issue in case someone has the time to look.
@st0012 st0012 added the bug label Nov 11, 2024
@flavorjones flavorjones changed the title (master) Ancestors list shows C symbol name instead of class In v6.8.1, C extension objects "Ancestors" list shows C symbol name instead of class name Nov 28, 2024
flavorjones added a commit to flavorjones/rdoc that referenced this issue Nov 28, 2024
@flavorjones
fix: C variables should never show up in Ancestors tree
ae631cb 
If a NormalClass's superclass is a C enclosure, then update the
superclass to point to the RDoc::NormalClass.

This is done in a single pass after all files have been parsed.

Fixes ruby#1205.
@flavorjones flavorjones linked a pull request Nov 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: C variables should never show up in Ancestors tree flavorjones/rdoc
2 participants
@flavorjones @st0012