Use the original label description list style
#1208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a default for all description lists, the original "label" style is more readable. This is slightly different from the original `label` dl though: * slightly increased left margin for `dd` (to 1em) * removed right margin on `dd` * removed `dt` bottom margin and `dd` top margin, to reduce the gap between the term and its description (to only the standard line-height gap).
|
Here are some screenshots. Please note that I did add a second v6.7.0:
current
|
|
I'll make a separate PR to bring back a distinct "note" style, so that can be judged separately from this. 🙂 But I also want to tweak some of the styling issues that I dislike about the original, so I might not get to it until later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a default for all description lists, the original "label" style is more readable.
This is slightly different from the original
labeldl though:dd(to 1em)dddtbottom margin andddtop margin, to reduce the gap between the term and its description to only the standard line-height gapSee the discussion at #1199. Because of that discussion, this PR gives both description lists the "label" style. A different PR (#1209) would also bring back distinct styling for the "note" list.