Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use distinct styles for note lists and label lists #1209

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Use distinct styles for note lists and label lists #1209

wants to merge 4 commits into from

Commits on Nov 15, 2024

  1. Use the original label description list style 

    As a default for all description lists, the original "label" style is
more readable.

This is slightly different from the original `label` dl though:
* slightly increased left margin for `dd` (to 1em)
* removed right margin on `dd`
* removed `dt` bottom margin and `dd` top margin, to reduce the gap
  between the term and its description (to only the standard line-height
  gap).
    @nevans
    nevans committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3afc357 View commit details
    Browse the repository at this point in the history

  2. Restore float:left style for note lists 

    Unlike the original note list styles, this version sets the line-height
for all `dt` elements to be the same as the `p` elements contained
inside the `dd`, so that the second line has the same indentation as all
subsequent lines.
    @nevans
    nevans committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    72ca1e0 View commit details
    Browse the repository at this point in the history

  3. Add closing tags for definition terms 

    Without the closing tags, the dt elements contain whitespace after the
text.  This normally isn't a big deal, but it messes some things up,
e.g: using `::after` and `content: ", "` in the stylesheets.
    @nevans
    nevans committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f64381d View commit details
    Browse the repository at this point in the history

  4. Add commas between note list terms

    @nevans
    nevans committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    827ed7c View commit details
    Browse the repository at this point in the history