Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReDoS by using repeated space characters inside <!DOCTYPE name [<!ATTLIST>]> #176

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Fix ReDoS by using repeated space characters inside <!DOCTYPE name [<!ATTLIST>]> #176

merged 2 commits into from
Jul 16, 2024

Conversation

Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Jul 16, 2024 •
edited by kou
Loading

Fix performance by removing unnecessary spaces.

This is occurred in Ruby 3.1 or earlier.

@Watson1978
Fix ReDoS by using repeated space characters inside `<!DOCTYPE name […
3819f9f 
…<!ATTLIST>]>`

Fix performance by removing unnecessary spaces.
kou
kou reviewed Jul 16, 2024
View reviewed changes
test/parse/test_attlist.rb Outdated Show resolved Hide resolved
@kou kou merged commit 1f1e6e9 into ruby:master Jul 16, 2024
61 checks passed
@kou
Copy link
Member

kou commented Jul 16, 2024

Thanks.

@Watson1978 Watson1978 deleted the fix-performance-7 branch July 17, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kou kou kou left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Watson1978 @kou