Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task-oriented documentation #64

Merged
merged 18 commits into from
Mar 8, 2021
Merged

Task-oriented documentation #64

merged 18 commits into from
Mar 8, 2021

Conversation

BurdetteLamar
Copy link
Member

@BurdetteLamar BurdetteLamar commented Mar 7, 2021

The important page is the master table of contents in ..\doc\rexml\tasks\tocs\master_toc.rdoc
The idea is to let the user find the relevant task, then follow a link to see code that does that.

I started out calling these recipes, but so far each is little, so I think task is a better term.

The best way to view these is to run RDoc and begin at the master toc html page.

@BurdetteLamar BurdetteLamar marked this pull request as draft March 7, 2021 22:28
@BurdetteLamar BurdetteLamar requested a review from kou March 7, 2021 22:29
@@ -0,0 +1,72 @@
Dir.chdir(File.dirname(__FILE__)) do
Copy link
Member

@kou kou Mar 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you define this as a rdoc:toc:generate Rake task in Rakefile?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you define this as a rdoc:toc:generate Rake task in Rakefile?

Sorry, I meant to say more (and better). My initial question is Do we want this sort of thing?

If yes, everything else can come later: correctness, robustness of TOC build, etc.

Also, Element is not completed, so there are some hanging issues there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's acceptable.

It's better that RDoc provides the TOC feature as a build-in feature. For example, [:toc:] is expanded to TOC on rendering phase. But it seems that RDoc doesn't provide the TOC feature. (Could you request the feature to RDoc?)

So it's reasonable that we have TOC generator for us for now.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's acceptable.

This is a lot of work, so needs to be much more than 'acceptable.' Do you like the 'task' concept?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I like the concept.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rakefile updated with task tocs:generate.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's acceptable.

It's better that RDoc provides the TOC feature as a build-in feature. For example, [:toc:] is expanded to TOC on rendering phase. But it seems that RDoc doesn't provide the TOC feature. (Could you request the feature to RDoc?)

So it's reasonable that we have TOC generator for us for now.

@kou, I have created the feature request: ruby/rdoc#801

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BurdetteLamar BurdetteLamar requested a review from kou March 8, 2021 21:09
@kou kou marked this pull request as ready for review March 8, 2021 21:37
@kou
Copy link
Member

kou commented Mar 8, 2021

Can we merge this pull request?
Do you still want to work on this pull request?

@BurdetteLamar
Copy link
Member Author

Can we merge this pull request?
Do you still want to work on this pull request?

Fine with me to merge. I'll continue in a new PR.

@kou kou merged commit 83bd4dc into ruby:master Mar 8, 2021
@kou
Copy link
Member

kou commented Mar 8, 2021

OK. I've merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants