-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Enable and use import maps #3209
Conversation
* Load all javascript needed to run the AdminLTE theme and | ||
* all the interactions. | ||
*/ | ||
import 'admin-lte' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heyapricot i was able to make the sidenav work again by importing it here after pinning it.
033fdab
to
fa0582e
Compare
@heyapricot I've made some updates since the last week. Mainly:
The next step I'd take is to make sure the system tests start passing again. Pick one or a few and try to get it to start passing by adding JS that may have been left out from https://github.com/rubyforgood/human-essentials/blob/main/app/assets/javascripts/application.js or need to be moved from the webpack version. This is exciting! |
@dorner as requested here is a list of things that still need to be fixed.
This list isn't all encompassing, these are just the most upfront issues I've seen so far. Happy to work with you to divide on conquer this if it makes sense :) |
FWIW, I believe you can use your phone as a bar code scanner. I don't know the details on that, though. |
You can use your computer's camera as well. If you click / tap in the barcode area it should automatically prompt you to use it. |
@@ -112,7 +110,7 @@ gem "clockwork" | |||
gem "mini_racer", "~> 0.6.3" | |||
gem "nokogiri", ">= 1.10.4" | |||
gem "image_processing" | |||
gem "sprockets", "~> 4.2.0" | |||
gem "sprockets", "~> 4.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to downgrade this due to rails/sprockets#749 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the system didn't like this downgrade very much :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In what way?
oh build is failing. That's weird, it wasn't doing that before :o Let me see if just running bundle will fix |
Should be fixed now. |
This only happens for the purchases -> new vendor popup. No idea why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know about the rest of the change, but I'd like to see the hack heavily commented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe we should put a tech debt issue in to solve it, though?
Honestly, it would be so far down in priority that I kind of hope nobody ever picks it up. We have a lot better fish to fry - for example, at some point we probably should upgrade to Bootstrap 5, which might render this moot depending on if there are fixes in there. |
Thank you for getting this merged! |
@heyapricot @dorner @edwinthinks Thanks for your work on this -- we just released it! |
Resolves #3199
Description
Type of change
How Has This Been Tested?
Screenshots