don’t rebuild already-built git gem extensions

closes #4082
rubygems · Feb 18, 2016 · cb39a17 · cb39a17
1 parent 4cad30f
commit cb39a17
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/bundler/source/git.rb b/lib/bundler/source/git.rb
@@ -222,6 +222,10 @@ def allow_git_ops?
 
     private
 
+      def build_extensions(installer)
+        super if installer.spec.missing_extensions?
+      end
+
       def serialize_gemspecs_in(destination)
         expanded_path = destination.expand_path(Bundler.root)
         Dir["#{expanded_path}/#{@glob}"].each do |spec_path|

diff --git a/lib/bundler/source/path.rb b/lib/bundler/source/path.rb
@@ -197,8 +197,7 @@ def generate_bin(spec, disable_extensions = false)
         SharedHelpers.chdir(gem_dir) do
           installer = Path::Installer.new(spec, :env_shebang => false)
           run_hooks(:pre_install, installer)
-          installer.build_extensions unless disable_extensions
-          run_hooks(:post_build, installer)
+          build_extensions(installer) unless disable_extensions
           installer.generate_bin
           run_hooks(:post_install, installer)
         end
@@ -216,6 +215,11 @@ def generate_bin(spec, disable_extensions = false)
         Bundler.ui.warn "The validation message from Rubygems was:\n  #{e.message}"
       end
 
+      def build_extensions(installer)
+        installer.build_extensions
+        run_hooks(:post_build, installer)
+      end
+
       def run_hooks(type, installer)
         hooks_meth = "#{type}_hooks"
         return unless Gem.respond_to?(hooks_meth)