Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Bundler silently ignores StandardError when loading files #3549

Closed
bricker opened this issue Apr 8, 2015 · 2 comments
Closed

Bundler silently ignores StandardError when loading files #3549

bricker opened this issue Apr 8, 2015 · 2 comments

Comments

@bricker
Copy link

bricker commented Apr 8, 2015

Example project, explanation of problem, expected/actual result, and steps to reproduce can be found here: https://github.com/bricker/bundler_require_fail

With commit f740c40 , a generic rescue block is wrapped around the Kernel.require line which loads your libraries. This block only outputs warning and debug text to Bundler.ui, which is NOT VISIBLE by default.

So, if the file being required throws any error inheriting from StandardError (most errors), the error is by default silently ignored and the file isn't loaded. This gives you confusing, unrelated errors that tell you nothing about the actual problem.

My suggestion is to either remove the generic rescue, or at least re-raise the error. Let me know the preferred fix and I can implement.

Thanks!

@indirect
Copy link
Member

indirect commented Apr 8, 2015

Yeah, I think reverting this is a good idea. Thanks for reporting!

indirect added a commit that referenced this issue Apr 8, 2015
This silently hides StandardErrors :(

Fixes #3549

This reverts commit f740c40.
@indirect
Copy link
Member

indirect commented Apr 8, 2015

This fix is released in 1.8.7, and will be released in 1.9.3 soon.

@indirect indirect closed this as completed Apr 8, 2015
indirect added a commit that referenced this issue Apr 8, 2015
This silently hides StandardErrors :(

Fixes #3549

This reverts commit f740c40.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants