Don't rebuild git extensions #4082
Conversation
| end | ||
|
|
||
| def gem_build_complete?(extensions_dir) | ||
| File.exists? gem_complete_path(extensions_dir) |
There was a problem hiding this comment.
warning: File.exists? is a deprecated name, use File.exist? instead
|
Looks like some of the CI failures are legit - I'll investigate. |
|
@csfrancis how's it going fixing the specs? This definitely seems like an improvement over the current state. 👍 |
|
Sorry, I haven't had time to look at this yet. I'll try to get to it in a couple days. |
|
This is a really hard issue to debug. I've probably spent at least 6-7 hours try to figure out where things are going wrong. At a high level, it looks like with the latest Rubygems master, the caching of Anyway, if I have time in the next few days I'll spent a bit more time trying to figure this out. |
| @@ -170,6 +170,9 @@ def install(spec, force = false) | |||
| serialize_gemspecs_in(install_path) | |||
| @copied = true | |||
| end | |||
|
|
|||
| return nil if gem_build_complete?(spec.extensions_dir) | |||
There was a problem hiding this comment.
any reason we can't just check spec.missing_extensions?
There was a problem hiding this comment.
arg, this seems to have broken more things :(
@indirect do we need to run git clean -xdf before switching branches?
There was a problem hiding this comment.
nope, we copy the git dir elsewhere as the gem dir, so I'm flummoxed
csfrancis
force-pushed
the
no_git_extension_recompile
branch
from
74ef5cc
to
adca156
Compare
csfrancis
force-pushed
the
no_git_extension_recompile
branch
from
adca156
to
2de560f
Compare
|
Ping did you guys end up making any progress on this? |
|
not yet, build still failing. want to take a stab at it? |
|
Closing in favor of #4272. |
@andremedeiros /cc @sirupsen
This is somewhat related to #4030 (and requires it to work). Bundler is not checking the
gem.build_completefor git extensions, and as a result is recompiling extensions when performing abundle install, for example.This PR simply checks if
gem.build_completeexists and bypasses the build step. This is a similar approach to what is done in Rubygems.In my Shopify development environment this brings
bundle installtime (when there are no Gemfile changes) from nearly 20 seconds to 3 seconds.