Remove global frozen when running install --no-deployment

[trevorturk]

This is a minor issue that I'm happy to work up a pull request for, but I'm wondering if anyone has opinions on how best to proceed.

The issue is that bundle install --no-deployment doesn't remove the global frozen flag if present. This can be worked around easily by using bundle config --delete frozen but Bundler suggests the problem will be solved by running bundle install --no-deployment.

Here's an example of how I ran into this issue:

$ bundle config --global frozen 1

$ bundle env
    Bundler   1.13.1
    Rubygems  2.2.5
    Ruby      2.1.10p492 (2016-04-01 revision 54464) [x86_64-darwin15.0]
    Git       2.10.0

Bundler settings

    frozen
      Set for the current user (/Users/trevorturk/.bundle/config): "1"

$ bundle install

You are trying to install in deployment mode after changing
your Gemfile. Run `bundle install` elsewhere and add the
updated Gemfile.lock to version control.

If this is a development machine, remove the /Users/trevorturk/Code/clearbit/company/Gemfile freeze 
by running `bundle install --no-deployment`.

$ bundle install --no-deployment

[...same error...]

$ bundle config --delete frozen
$ bundle install

[...success...]

I believe the best fix would be to delete the local and global setting via: https://github.com/bundler/bundler/blob/master/lib/bundler/cli/install.rb#L48-L52 which might mean adjusting Bundler::Settings#delete to also delete global settings here https://github.com/bundler/bundler/blob/master/lib/bundler/settings.rb#L99-L101 or to introduce a new Bundler::Settings#delete_global or such and delete the global setting when install is called with --no-deployment.

Another possible fix might be adjusting the error message to suggest running bundle config --delete frozen instead of bundle install --no-deployment but that would leave out the options[:system] = true tweak, and I'm not quite sure if that would cause problems.

[segiddins]

The only thing that should be touching the global config is bundle config --global, in my opinion. I think maybe the solution here is to just check where the frozen setting is coming from, and suggest deleting it if it's not coming from the app config?

[trevorturk]

You can see from the code snippet I pasted above that I ran bundle config --global frozen 1 -- this was part of my attempt to debug #5006 because that's what the Dockerfile I inherited contained.

Regardless of where the global config came from, however, the problem I'd like to fix is that the suggested fix from the Bundler error message doesn't work as it doesn't remove the global config. WDYT?

(Again, apologies, I must be really annoying by now :)

[segiddins]

I agree that the right thing to fix is the error message :)

[trevorturk]

Ok, I'll work up a PR that suggests running bundle config --delete frozen if bundle install --no-deployment doesn't work. Thanks!

[segiddins]

we can also detect where the settings are set and be smart about it that way