Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Bundle clean --dry-run should print listing without --force when no path is set #5027

Closed
hmistry opened this issue Sep 28, 2016 · 2 comments
Closed

Comments

@hmistry
Copy link
Contributor

hmistry commented Sep 28, 2016

Currently if path is not set, bundle clean --dry-run requires --force to print listing. It would be nice if it bundler followed the common paradigms where --dry-run prints a listing of what changes without --force, and --force is only required when you're prevented from executing the action for some reason and you need to override the failsafes and force the action.

Propose change current bundle clean --dry-run --force to bundle clean --dry-run for the case when path is not set.

@hmistry
Copy link
Contributor Author

hmistry commented Oct 4, 2016

I'm working on a PR for this.

@hmistry
Copy link
Contributor Author

hmistry commented Oct 5, 2016

Done, see PR #5053.

homu added a commit that referenced this issue Oct 10, 2016
Changed the behavior of 'bundle clean --dry-run' to output the list regardless of path set or force option

Changed the behavior of 'bundle clean --dry-run' to output the list of gems bundle without having the local path set or providing the '--force' option. This change does not affect the actual behavior of 'bundle clean' which requires either the path being set or use of '--force'.

Closes #5027.
homu added a commit that referenced this issue Oct 14, 2016
Changed the behavior of 'bundle clean --dry-run' to output the list regardless of path set or force option

Changed the behavior of 'bundle clean --dry-run' to output the list of gems bundle without having the local path set or providing the '--force' option. This change does not affect the actual behavior of 'bundle clean' which requires either the path being set or use of '--force'.

Closes #5027.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants