Bundler crashes when force_ruby_platform is set to true

[larskanis]

This is in response to #5337 .

Error Report

Questions

Please fill out answers to these questions, it'll help us figure out
why things are going wrong.

• What did you do?

  I ran the command

C:\Users\lars\railstest>bundle config force_ruby_platform true
C:\Users\lars\railstest>bundle

• What did you expect to happen?

  I expected Bundler to install only platform=ruby gems and ignore any native gems.

• What happened instead?

  Instead, what happened was that bundler crashed with this exception.

• Have you tried any solutions posted on similar issues in our issue tracker, stack overflow, or google?

  I tried bundle lock --add-platform=ruby and bundle lock --add-platform=ruby --remove-platform=x86-mingw32 as alternatives, which don't crash, but get unexpected results. See issue Bundler doesn't respect other than the native platform while resolving the gems to install #5337 .

• Have you read our issues document, https://github.com/bundler/bundler/blob/master/ISSUES.md?

  ... Good to know - I probably should.

Backtrace

NoMethodError: undefined method `os' for "ruby":String
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/current_ruby.rb:65:in `mingw?'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/dependency.rb:123:in `block in current_platform?'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/dependency.rb:122:in `any?'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/dependency.rb:122:in `current_platform?'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/dependency.rb:106:in `should_include?'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/definition.rb:894:in `block in compute_requires'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/definition.rb:893:in `each'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/definition.rb:893:in `reduce'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/definition.rb:893:in `compute_requires'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/definition.rb:120:in `initialize'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/dsl.rb:200:in `new'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/dsl.rb:200:in `to_definition'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/dsl.rb:12:in `evaluate'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/definition.rb:33:in `build'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler.rb:128:in `definition'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/cli/install.rb:67:in `run'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/cli.rb:181:in `block in install'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/settings.rb:98:in `temporary'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/cli.rb:180:in `install'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/vendor/thor/lib/thor.rb:359:in `dispatch'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/cli.rb:20:in `dispatch'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/vendor/thor/lib/thor/base.rb:440:in `start'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/cli.rb:11:in `start'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/exe/bundle:32:in `block in <top (required)>'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/lib/bundler/friendly_errors.rb:121:in `with_friendly_errors'
  C:/Ruby24/lib/ruby/gems/2.4.0/gems/bundler-1.14.0/exe/bundle:24:in `<top (required)>'
  C:/Ruby24/bin/bundle:22:in `load'
  C:/Ruby24/bin/bundle:22:in `<main>'

Environment

Bundler   1.14.0
Rubygems  2.6.8
Ruby      2.4.0p0 (2016-12-24 revision 57164) [i386-mingw32]
GEM_HOME  C:/Ruby24/lib/ruby/gems/2.4.0
GEM_PATH  C:/Ruby24/lib/ruby/gems/2.4.0;C:/Users/lars/.gem/ruby/2.4.0
Git       2.5.0.windows.1
Platform  x86-mingw32
OpenSSL   OpenSSL 1.0.2j  26 Sep 2016

Bundler settings

build.nokogiri
  Set for the current user (C:/Users/lars/.bundle/config): "--use-system-libraries --with-xml2-include=c:/msys64/mingw64/include/libxml2 --with-xslt-dir=c:/msys64/mingw64"
force_ruby_platform
  Set for the current user (C:/Users/lars/.bundle/config): "true"

[segiddins]

Can you please also include your Gemfile?

[larskanis]

The corresponding Gemfile: https://gist.github.com/larskanis/a1769c8abca6577c6d0d640889965d5b

[segiddins]

#5345 should fix this!

[larskanis]

Yes, #5345 fixes this issue.