Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Invalid Github URL in README #5438

Closed
danielpclark opened this issue Feb 16, 2017 · 2 comments · Fixed by #5439
Closed

Invalid Github URL in README #5438

danielpclark opened this issue Feb 16, 2017 · 2 comments · Fixed by #5439
Labels
type: bug report

Comments

@danielpclark
Copy link
Contributor

danielpclark commented Feb 16, 2017 •
edited
Loading

Bundler version 1.14.3

With using

bundle gem example

The README.md file under contributions shows as:

https://github.com/Daniel P. Clark/example

This is taken from git config --get user.name (I believe)

The command that should be used is git config --get github.user which would result in:

https://github.com/danielpclark/example
@olleolleolle
Copy link
Member

(Snooping around: These are the locations where the data is dug up and used.)

https://github.com/bundler/bundler/blob/master/lib/bundler/cli/gem.rb#L32

https://github.com/bundler/bundler/blob/master/lib/bundler/templates/newgem/README.md.tt#L35

Would you want to author a PR about this?

@danielpclark
Copy link
Contributor Author

Sure, I'd love to!

@danielpclark danielpclark mentioned this issue Feb 16, 2017
Merged
bundlerbot added a commit that referenced this issue Feb 17, 2017
@bundlerbot
Auto merge of #5439 - danielpclark:patch_gh_username, r=segiddins
14bfe7a 
Fix Github username for README.md contrib URL

This fixes #5438 where the wrong git config variable was being
retrieved.

This was using `git config user.name` rather than `git config github.user` in URL in `README.md`
Shekharrajak pushed a commit to Shekharrajak/bundler that referenced this issue Feb 20, 2017
@danielpclark @Shekharrajak
Fix Github username for README.md contrib URL
e9113a8 
This fixes rubygems#5438 where the wrong git config variable was being
retrieved.

Renamed user name to author name & specs added

`git_user_name` renamed to `git_author_name` and tests added for genuine
`git_user_name` to verify proper URL in README.md.

Renamed `git_user_name` to `github_username` per @segiddins request.

Rubocop style fix on hash k,v spacing

Replace backticks with `sys_exec` per @segiddins.  Hat-tip to
@olleolleolle for explaining `sys_exec` from `spec_helpers/support.rb`
is a helper method that smooths the path for the RSpec usage in the
project. (Thank you.)
segiddins pushed a commit that referenced this issue Feb 22, 2017
@bundlerbot @segiddins
Auto merge of #5439 - danielpclark:patch_gh_username, r=segiddins
875311b 
Fix Github username for README.md contrib URL

This fixes #5438 where the wrong git config variable was being
retrieved.

This was using `git config user.name` rather than `git config github.user` in URL in `README.md`

(cherry picked from commit 14bfe7a)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Github username for README.md contrib URL
3 participants
@olleolleolle @danielpclark @segiddins