Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Bundle init failed when ancestor directory has Gemfile #6205

Closed
kyoshidajp opened this issue Dec 8, 2017 · 4 comments · Fixed by #6207
Closed

Bundle init failed when ancestor directory has Gemfile #6205

kyoshidajp opened this issue Dec 8, 2017 · 4 comments · Fixed by #6207
Labels
type: bug report

Comments

@kyoshidajp
Copy link

Steps to reproduce

% tree sample
sample
├── Gemfile
└── hoge
% cd sample/hoge
% bundle init
/Users/kyoshida/work/sample/Gemfile already exists at /Users/kyoshida/work/sample/Gemfile

Expected behavior

Gemfile is generated in hoge directory.

Because bundle init document says the following.

bundle-init - Generates a Gemfile into the current working directory

I believe that current woking is the same as $PWD's value.

However, the code is intentionally looking for ancestor directories.

  1. https://github.com/bundler/bundler/blob/v1.16.0/lib/bundler/cli/init.rb#L40
  2. https://github.com/bundler/bundler/blob/v1.16.0/lib/bundler/shared_helpers.rb#L240

This behavior is in the specifications?

Version

Bundler version 1.16.0
@colby-swandale
Copy link
Member

Thanks for the report. I have a fix for this.

@kibitan
Copy link

kibitan commented Dec 9, 2017 •
edited
Loading

I also get same problem of this. @colby-swandale can you fix it soon? I searched the cause, can i give the pull-request for it?

@colby-swandale colby-swandale mentioned this issue Dec 9, 2017
Merged
bundlerbot added a commit that referenced this issue Dec 11, 2017
@bundlerbot
Auto merge of #6207 - bundler:colby/init-gemfile-path-child, r=segiddins
8de8086 
Let users generate gemfiles inside paths whos parent contains a Gemfile

### What was the end-user problem that led to this PR?

Users are unable to generate a new Gemfile with `bundle init` if there is a Gemfile in any
parent folder.

See #6205

### What is your fix for the problem, implemented in this PR?

Don't use `SharedHelpers.default_gemfile` as that searches up the paths for a Gemfile. Instead only check the current directory.
@segiddins
Copy link
Member

#6207 will fix this

@kibitan
Copy link

kibitan commented Dec 11, 2017

super! thanks 😄

bundlerbot added a commit that referenced this issue Dec 11, 2017
@bundlerbot
Auto merge of #6207 - bundler:colby/init-gemfile-path-child, r=segiddins
060e2f9 
Let users generate gemfiles inside paths whos parent contains a Gemfile

### What was the end-user problem that led to this PR?

Users are unable to generate a new Gemfile with `bundle init` if there is a Gemfile in any
parent folder.

Closes #6205

### What is your fix for the problem, implemented in this PR?

Don't use `SharedHelpers.default_gemfile` as that searches up the paths for a Gemfile. Instead only check the current directory.
hsbt pushed a commit that referenced this issue Dec 12, 2017
@bundlerbot @hsbt
Auto merge of #6207 - bundler:colby/init-gemfile-path-child, r=segiddins
8e852c8 
Let users generate gemfiles inside paths whos parent contains a Gemfile

### What was the end-user problem that led to this PR?

Users are unable to generate a new Gemfile with `bundle init` if there is a Gemfile in any
parent folder.

Closes #6205

### What is your fix for the problem, implemented in this PR?

Don't use `SharedHelpers.default_gemfile` as that searches up the paths for a Gemfile. Instead only check the current directory.
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Mar 14, 2018
misc/ruby-bundler: update to 1.16.1
edf63a3 
## 1.16.1 (2017-12-12)

Bugfixes:

  - avoid hanging on complex resolver errors ([#6114](rubygems/bundler#6114), @halfbyte)
  - avoid an error when running `bundle update --group` ([#6156](rubygems/bundler#6156), @mattbrictson)
  - ensure the resolver prefers non-pre-release gems when possible ([#6181](rubygems/bundler#6181), @greysteil)
  - include bundler's gemspec in the built gem ([#6165](rubygems/bundler#6165), @dr-itz)
  - ensure locally installed specs are not overriden by those in remote sources during dependency resolution ([#6072](rubygems/bundler#6072), @indirect)
  - ensure custom gemfiles are respected in generated binstubs (@pftg)
  - fail gracefully when loading a bundler-generated binstub when `bin/bundle` was not generated by bundler ([#6149](rubygems/bundler#6149), @hsbt)
  - allow `bundle init` to be run even when a parent directory contains a gemfile ([#6205](rubygems/bundler#6205), @colby-swandale)

## 1.16.0 (2017-10-31)

Bugfixes:

  - avoid new RubyGems warning about unsafe YAML loading (to keep output consistent) (@segiddins)
  - load digest subclasses in a thread-safe manner (@segiddins, @colby-swandale)
  - avoid unusued variable warnings under ruby 2.5 (@amatsuda)
  - fix printing the same message twice in verbose mode ([#6028](rubygems/bundler#6028), @akhramov)
  - allow `SignalException`s to bubble up to the interpreter during `bundle exec` ([#6090](rubygems/bundler#6090), @dekellum)
  - avoid activating stdlib digest under Ruby 2.5 (@segiddins)
  - prioritise explicitly requested gems in dependency resolution sort order (@segiddins)
  - reduce memory usage during dependency resolution ([#6114](rubygems/bundler#6114), @greysteil)
  - ensure that the default bundler gem is not accidentally activated on ruby 2.5 when using local git overrides (@segiddins)

## 1.16.0.pre.3 (2017-10-04)

Features:

  - the output from `bundle env` includes more information, particularly both the compiled & loaded versions of OpenSSL (@indirect)

Bugfixes:

  - fix a bug where installing on FreeBSD would accidentally raise an error (#6013, @olleolleolle)
  - fix a regression in 1.16 where pre-release gems could accidentally be resolved even when the gemfile contained no pre-release requirements (@greysteil)
  - bundler will avoid making unnecessary network requests to fetch dependency data, fixing a regression introduced in 1.16 (@segiddins)
  - the outdated bundler version message is disabled by default until the message has been fine-tuned (#6004, @segiddins)

## 1.16.0.pre.2 (2017-09-06)

Bugfixes:

  - handle when a connection is missing a socket when warning about OpenSSL version (@greysteil)
  - the description for the `rake release` task now reflects `$RUBYGEMS_HOST` (@wadetandy)
  - fix a bug where `bundle update` would regress transitive dependencies (@greysteil)

## 1.16.0.pre.1 (2017-09-04)

Features:

  - allow using non-branch symbolic refs in a git source (#4845, @segiddins)
  - allow absolute paths in the `cache path` setting (#5627, @mal)
  - gems created via `bundle gem` with rspec have `--require spec_helper` in their `.rspec` file (@koic)
  - `bundle env` includes `Gem.ruby` and the `bundle` binstub shebang when they don't match (#5616, @segiddins)
  - allow passing gem names to `bundle pristine` (@segiddins)
  - `bundle version` and `bundle env` include the commit and build date for the bundler gem (#5049, @segiddins)
  - add the `--shebang` option to `bundle binstubs` (#4070, @segiddins, @zorbash)
  - gemfiles are `eval`ed one fewer time when running `bundle install` (#4952, #3096, #4417, @segiddins)
  - the `fileutils` gem is now vendored so different versions of the gem can be activated (@segiddins)
  - speed up no-op installations (#5842, @segiddins)
  - default to keeping the lockfile in the default gem template (@deivid-rodriguez)
  - add a special bundler binstub that ensures the correct version of bundler is activated (#5876, @segiddins)
  - speed up dependency resolution and ensure that all resolvable gemfiles can be installed (@segiddins, @greysteil)
  - add a `bundle list` command that prints the gems in use (#4754, @colby-swandale)
  - allow adding credentials to a gem source during deployment when `allow_deployment_source_credential_changes` is set (@adrian-gomez)
  - making an outdated (and insecure) TLS connection to rubygems.org will print a warning (@segiddins)

Bugfixes:

  - allow configuring a mirror fallback timeout without a trailing slash (#4830, @segiddins)
  - fix handling of mirrors for file: urls that contain upper-case characters (@segiddins)
  - list the correct gem host for `rake release` when `allowed_push_host` has been set (@mdeering)
  - ensure `Bundler.original_env` preserves all env keys that bundler sets (#5700, @segiddins)
  - ensure `bundle pristine` removes files added to a git gem (@segiddins)
  - load plugin files from path gems before gem installation (#5429, @segiddins)
  - ensure gems containing manpages are properly set up (#5730, @segiddins)
  - avoid fetching remote specs when all effected gems are in groups that are not being installed (@segiddins)
  - allow `BUNDLE_GEMFILE` to be a relative path (#5712, @gxespino)
  - show a more helpful error message when a gem fails to install due to a corrupted lockfile (#5846, @segiddins)
  - add a process lock to allow multiple concurrent `bundle install`s (#5851, @stefansedich)
  - ensure that specifications always return an array for `#extensions` (@greysteil)
  - print a helpful error message when using a gem in the Gemfile with an empty name (@colby-swandale)
  - ensure that all gemfiles are included in `bundle env` (@segiddins)
  - use ssl client cert and ca cert settings from gem configuration as fallbacks (@stan3)
  - avoid global namespace pollution when loading gems (#5958, @shyouhei)
  - avoid running a complete re-resolve on `bundle update --bundler` (@segiddins)
  - allow `bundle binstubs --standalone` to work without `path` being set (@colby-swandale)
  - fix support for bundle paths that include jars or wars on jruby (#5975, @torcido)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Let users generate gemfiles inside paths whos parent contains a Gemfile rubygems/bundler
4 participants
@kibitan @colby-swandale @segiddins @kyoshidajp