Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Fix universal gem installation issues #3553

Closed
wants to merge 3 commits into from
Closed

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Apr 9, 2015

Trying to install win32-api on windows 64-bit ruby since it is published as a universal-mingw32 gem instead of x64-mingw32.
This patch should fix #3066

@indirect
Copy link
Member

indirect commented Apr 9, 2015

Thanks for the patch! Can you write a test, or at least describe how to test this, so we can make sure that it's actually fixed?

@jaym
Copy link
Contributor Author

jaym commented Apr 9, 2015

Happy to write the tests, probably goes in https://github.com/bundler/bundler/blob/master/spec/resolver/platform_spec.rb?
The case this covers is where the gem has a universal cpu

Any ideas why travis is not running? I wasn't actually able to run any of the specs on windows and was hoping I could see if I broke anything.

@indirect
Copy link
Member

Travis isn't running because you created a branch whose name isn't in the travis whitelist, I think? You could add "universal" to the branch list in .travis.yml in a separate commit that I won't cherry-pick, if you like.

@jaym
Copy link
Contributor Author

jaym commented Apr 10, 2015

I'm not sure if that's the reason, but let's give it a shot.
Travis should build PRs against branches that are whitelisted, and master is whitelisted.

@jaym
Copy link
Contributor Author

jaym commented Apr 10, 2015

Looks like it worked. Anyway, specs added

@indirect
Copy link
Member

awesome, thanks!

@indirect
Copy link
Member

Cherry picked as bd078f2 and b7d5d90.

@indirect indirect closed this Apr 11, 2015
@jaym jaym deleted the universal branch April 13, 2015 17:10
jaym added a commit to chef/chef that referenced this pull request Apr 13, 2015
rubygems/bundler#3553 broke universal gems completely

We can unpin once a fix is released
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Universal gems do not match x64-mingw32 platform
2 participants