This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3443 (nmarley's problem at the bottom)
The issue was that
alpha =~ beta
returns nil ifalpha
doesn't containbeta
and the position—e.g. 6—instead offalse
andtrue
respectively like was assumed by whomever wrote the original logic. It coincidentely worked for yes because everything—like 6 using my above example—except forfalse
andnil
resolve totrue
. However, when they selected no for coc or mit they were always reasked because it resolved tonil
which for boolean settings doesn't get transformed intofalse
.