This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Clean RUBYLIB as well in with_clean_env
#4002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@indirect The original branch ( I didn't yet squash for clarity (I'll squash after the review). |
|
Looks good! 👍🏻 |
|
Squashed. |
|
@homu r+ |
|
📌 Commit 42b5072 has been approved by |
homu
added a commit
that referenced
this pull request
Sep 20, 2015
Clean RUBYLIB as well in `with_clean_env` Fixes #3982.
|
☀️ Test successful - status |
|
Please take a look @ bundler/issues#4165, looks like this commit has broken rails's spring. |
sonalkr132
added a commit
to sonalkr132/spring
that referenced
this pull request
Jan 23, 2016
ENV["GEM_PATH"] was empty string, so GEM_PATH and GEM_HOME passed to server process were same path. It used to work before bundler 1.11.0 release cause bundler didn't clean ENV["RUBYLIB"] and `require bundler/setup` was using that instead. Change in bundler: rubygems/bundler#4002
sonalkr132
added a commit
to sonalkr132/spring
that referenced
this pull request
Jan 23, 2016
ENV["GEM_PATH"] was empty string, so GEM_PATH and GEM_HOME passed to server process were same path. It used to work before bundler 1.11.0 release cause bundler didn't clean ENV["RUBYLIB"] and `require bundler/setup` was using that instead. Change in bundler: rubygems/bundler#4002
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3982.