This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Restrict platforms when using gemspec in DSL #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the gemspec This fixes rubygems#4102
|
Awesome @smellsblue ! Can we also get a spec that attempts to install the whole gemfile, just to be sure? |
|
@indirect this look good to you? |
|
@homu r+ |
|
📌 Commit 4b7a940 has been approved by |
homu
added a commit
that referenced
this pull request
Nov 27, 2015
Restrict platforms when using gemspec in DSL When referencing a `gemspec` in the `Gemfile`, restrict what platforms to check against to just those defined by the `gemspec` itself. This fixes #4102
|
☀️ Test successful - status |
jowl
pushed a commit
to iconara/rubydoop
that referenced
this pull request
Dec 15, 2015
Since Bundler v1.11.0 (or specifically rubygems/bundler#4114), Bundler no longer installs dependencies of local gems whose platform doesn't match the local gemspec.
glennpratt
added a commit
to glennpratt/bundler
that referenced
this pull request
Feb 1, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When referencing a
gemspecin theGemfile, restrict what platforms to check against to just those defined by thegemspecitself.This fixes #4102