-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Add original error context info to GemRequireError message #4187
Add original error context info to GemRequireError message #4187
Conversation
Hm, actually, @indirect, any tips on a quick way to reproduce the error condition without requiring something running stuff in a Docker container or uninstalling my node environment? I'd like to check the formatting and see if it's clean looking. |
super(msg) | ||
full_message = msg + "\nError was: #{orig_exception.message}\n"\ | ||
"Backtrace for gem load error was:\n"\ | ||
"#{orig_exception.backtrace.inspect}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backtrace should be joined rather than inspected.
Build a gem that just raises in the file bundler will attempt to require? |
Got y'all. Updated the PR with a change to the appropriate spec and updated the formatting.
The backtrace for the gem load error would, for the |
👍🏻 |
@homu r+ |
📌 Commit 85d6cea has been approved by |
…or, r=indirect Add original error context info to GemRequireError message Addresses #4182.
☀️ Test successful - status |
@RochesterinNYC what is the simplest way to pick up this fix considering that the new version of Bundler won't be released for a while? |
@emirkin a new release of If you really don't want to wait for it, though, you can install |
@RochesterinNYC Thanks! |
Addresses #4182.