Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Remove psyched_yaml #4916

Merged
merged 3 commits into from
Sep 30, 2016
Merged

Remove psyched_yaml #4916

merged 3 commits into from
Sep 30, 2016

Conversation

segiddins
Copy link
Member

Closes #4825
See #4856

@indirect
Copy link
Member

is that the only place we ever required the file? do we still need to require psych, or are we completely independent of it now for Bundler itself?

@segiddins
Copy link
Member Author

RubyGems will handle loading psych internally in these places

@indirect
Copy link
Member

@homu r+

@homu
Copy link
Contributor

homu commented Aug 28, 2016

📌 Commit 3371479 has been approved by indirect

homu added a commit that referenced this pull request Aug 28, 2016
@homu
Auto merge of #4916 - bundler:seg-remove-pysched-yaml, r=indirect
1bea775 
Remove psyched_yaml

Closes #4825
See #4856
@homu
Copy link
Contributor

homu commented Aug 28, 2016

⌛ Testing commit 3371479 with merge 1bea775...

@homu
Copy link
Contributor

homu commented Aug 28, 2016

💔 Test failed - status

@segiddins
Copy link
Member Author

Blocked on #4928

@segiddins
Copy link
Member Author

@homu retry

homu added a commit that referenced this pull request Aug 29, 2016
@homu
Auto merge of #4916 - bundler:seg-remove-pysched-yaml, r=indirect
118897e 
Remove psyched_yaml

Closes #4825
See #4856
@homu
Copy link
Contributor

homu commented Aug 29, 2016

⌛ Testing commit 3371479 with merge 118897e...

@homu
Copy link
Contributor

homu commented Aug 29, 2016

💔 Test failed - status

@segiddins segiddins changed the base branch from seg-2-0-dev-fixes to 2-0-dev September 2, 2016 14:38
@segiddins
Copy link
Member Author

@homu r+

@homu
Copy link
Contributor

homu commented Sep 2, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@homu
Copy link
Contributor

homu commented Sep 2, 2016

📌 Commit 3371479 has been approved by segiddins

@homu
Copy link
Contributor

homu commented Sep 2, 2016

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

@segiddins
Copy link
Member Author

@homu retry

homu added a commit that referenced this pull request Sep 2, 2016
@homu
Auto merge of #4916 - bundler:seg-remove-pysched-yaml, r=segiddins
7a093b9 
Remove psyched_yaml

Closes #4825
See #4856
@homu
Copy link
Contributor

homu commented Sep 2, 2016

⌛ Testing commit 3371479 with merge 7a093b9...

@homu
Copy link
Contributor

homu commented Sep 2, 2016

💔 Test failed - status

@segiddins segiddins closed this Sep 2, 2016
@segiddins segiddins reopened this Sep 2, 2016
@homu
Copy link
Contributor

homu commented Sep 2, 2016

💡 This pull request was already approved, no need to approve it again.

1 similar comment
@homu
Copy link
Contributor

homu commented Sep 2, 2016

💡 This pull request was already approved, no need to approve it again.

@segiddins
Copy link
Member Author

@homu r+

@homu
Copy link
Contributor

homu commented Sep 6, 2016

📌 Commit 6b4c1d4 has been approved by segiddins

homu added a commit that referenced this pull request Sep 6, 2016
@homu
Auto merge of #4916 - bundler:seg-remove-pysched-yaml, r=segiddins
286e12f 
Remove psyched_yaml

Closes #4825
See #4856
@homu
Copy link
Contributor

homu commented Sep 6, 2016

⌛ Testing commit 6b4c1d4 with merge 286e12f...

@homu
Copy link
Contributor

homu commented Sep 6, 2016

💔 Test failed - status

@segiddins
Copy link
Member Author

I can't seem to get that one failure to reproduce locally

@segiddins
Copy link
Member Author

Got it to reproduce, leading me to question how any other Ruby was passing at all. ¯\_(ツ)_/¯

homu and others added 2 commits September 22, 2016 12:17
@homu @segiddins
Auto merge of #4990 - bundler:seg-realworld-flex, r=segiddins
ff8871d 
Dynamically fetch expected rails version

This way, we don't have to update this expectation every time a new rails version comes out
@segiddins
Update resolving spec for RG master using a specific exception
7428308
@indirect indirect mentioned this pull request Sep 27, 2016
Closed
14 tasks
@indirect
Copy link
Member

I love the fix for Rails versions 😂

@homu r+

@homu
Copy link
Contributor

homu commented Sep 30, 2016

📌 Commit 7428308 has been approved by indirect

@homu
Copy link
Contributor

homu commented Sep 30, 2016

⚡ Test exempted - status

@homu homu merged commit 7428308 into 2-0-dev Sep 30, 2016
homu added a commit that referenced this pull request Sep 30, 2016
@homu
Auto merge of #4916 - bundler:seg-remove-pysched-yaml, r=indirect
16fcbf7 
Remove psyched_yaml

Closes #4825
See #4856
@coilysiren coilysiren added this to the 2.0 — Breaking Changes milestone Oct 9, 2016
@hsbt hsbt deleted the seg-remove-pysched-yaml branch December 22, 2017 05:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0 — Breaking Changes
Development

Successfully merging this pull request may close these issues.
4 participants
@segiddins @indirect @homu @coilysiren