This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[Settings] Allow temporarily overriding settings in-memory #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you explain the rationale for this? |
|
Sure! We use settings in two ways -- one is user preferences, stored via |
segiddins
force-pushed
the
seg-settings-temporary
branch
from
5dacde2
to
3b6dd37
Compare
|
@homu r+ That's a good point about these being two separate things—maybe we will want to make them explicitly different in the future? |
|
📌 Commit 3b6dd37 has been approved by |
homu
added a commit
that referenced
this pull request
Aug 28, 2016
[Settings] Allow temporarily overriding settings in-memory
|
💔 Test failed - status |
|
Blocked on #4928 |
|
@homu retry |
homu
added a commit
that referenced
this pull request
Aug 29, 2016
[Settings] Allow temporarily overriding settings in-memory
|
☀️ Test successful - status |
homu
added a commit
that referenced
this pull request
Aug 31, 2016
Add some specs for Bundler::Settings#temporary This PR adds a spec and moved an alias in Settings class. followup of #4917.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.