Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

[RubyGems] Ignore specs missing extensions #5217

Merged
merged 2 commits into from
Dec 1, 2016

Conversation

segiddins
Copy link
Member

Closes #5210 but I'm not entirely convinced that this is necessary

@indirect
Copy link
Member

@segiddins necessary in what sense? (Also, do you have a sense of the performance impact of this change on an app with 500 gems?)

@segiddins
Copy link
Member Author

Necessary in the sense of requiring the extension will still work if its installed globally, or fail otherwise, even without this change. And no, didn't profile it yet. Keep in mind that it can short-circuit in an RG with stubs for gems that don't include extensions

@segiddins segiddins force-pushed the seg-rubygems-ignore-missing-exts branch from 6f59d78 to 1f10c7f Compare November 30, 2016 15:50
@segiddins
Copy link
Member Author

This is green, fyi

@indirect
Copy link
Member

indirect commented Dec 1, 2016

@bundlerbot r+

@bundlerbot
Copy link
Collaborator

📌 Commit 1f10c7f has been approved by indirect

@bundlerbot
Copy link
Collaborator

⚡ Test exempted - status

@bundlerbot bundlerbot merged commit 1f10c7f into master Dec 1, 2016
@kirs
Copy link
Contributor

kirs commented Dec 1, 2016

Thanks @segiddins!

@segiddins segiddins deleted the seg-rubygems-ignore-missing-exts branch December 1, 2016 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants