This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[Env] Print shebang when it doesnt match Gem.ruby #5703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
commented
Jun 4, 2017
lib/bundler/env.rb
Outdated
| specs = Bundler.rubygems.find_name(name) | ||
| out << "#{name} (#{specs.map(&:version).join(",")})\n" unless specs.empty? | ||
| env = environment | ||
| environment_ljust = env.map {|(k, _v)| k.to_s.length }.max |
There was a problem hiding this comment.
_v is giving an unused variable warning on < 2
segiddins
force-pushed
the
seg-environment-shebang-mismatch
branch
from
b897fec
to
b272df0
Compare
|
oh my god what a good idea yes please @bundlerbot r+ |
|
📌 Commit b272df0 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Jun 12, 2017
…irect [Env] Print shebang when it doesnt match Gem.ruby Closes #5616. Prints out `Gem.ruby` and the `bundle` binstub shebang when they don't match, which should help us pinpoint when ruby installation shenanigans are the root cause of an issue
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5616.
Prints out
Gem.rubyand thebundlebinstub shebang when they don't match, which should help us pinpoint when ruby installation shenanigans are the root cause of an issue