This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[2.0] Implement config subcommands #5981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any tests for this? |
|
Not yet, need to add them if we're happy with the UX |
|
Specs added @colby-swandale ! |
segiddins
force-pushed
the
seg-cleanup-config
branch
from
744fd6c
to
538dae8
Compare
segiddins
changed the title
| bundle! "config get foo" | ||
| expect(last_command.stdout).to eq "Settings for `foo` in order of priority. The top value will be used\nYou have not configured a value for `foo`" | ||
|
|
||
| ENV["BUNDLE_FOO"] = "foo_val" |
There was a problem hiding this comment.
I would like to encouraging using context blocks here but i'm not super fussed right now.
There was a problem hiding this comment.
That just makes the specs slower though
colby-swandale
approved these changes
Aug 31, 2017
|
@indirect r? |
|
This is great, thanks! @bundlerbot r+ |
|
📌 Commit 538dae8 has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Sep 5, 2017
[2.0] Implement config subcommands ### What was the end-user problem that led to this PR? The problem was the current `bundle config` mega-command is hacky and confusing. ### What was your diagnosis of the problem? My diagnosis was we should add subcommands for `list`, `get`, `set`, and `unset` to make the CLI clearer. Closes #4600. ### What is your fix for the problem, implemented in this PR? My fix implements those subcommands while preserving the current bare `bundle config` command. ### Why did you choose this fix out of the possible options? I chose this fix because, as opposed to #5507, we can keep the existing command in for a little while to help ease the transition. @denniss how do you feel about this compared to your PR?
|
☀️ Test successful - status-travis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was the current
bundle configmega-command is hacky and confusing.What was your diagnosis of the problem?
My diagnosis was we should add subcommands for
list,get,set, andunsetto make the CLI clearer.Closes #4600.
What is your fix for the problem, implemented in this PR?
My fix implements those subcommands while preserving the current bare
bundle configcommand.Why did you choose this fix out of the possible options?
I chose this fix because, as opposed to #5507, we can keep the existing command in for a little while to help ease the transition.
@denniss how do you feel about this compared to your PR?