Remove a blank line in generated gemspec for RUBY_VERSION >= "2.0.0" #6123
Conversation
|
Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack. For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide |
Fix failing spec for `bundle plugin list` ### What was the end-user problem that led to this PR? The problem was failure of Travis CI build. (refs: [build for #6123](https://travis-ci.org/bundler/bundler/builds/292436821?utm_source=github_status&utm_medium=notification)) ### What was your diagnosis of the problem? Bundler::Plugin::Index#installed_plugins is keys of Hash, and Hash is not ordered in prior to Ruby 1.9. `foo` and `bar` plugins defined in spec are not always listed in specified order. ### What is your fix for the problem, implemented in this PR? My fix is to separate tests into for Ruby < 1.9 or not. ### Why did you choose this fix out of the possible options? I chose this fix because this makes code easy to remove if we stop building Ruby < 1.9 in Travis CI.
|
Test passed since #6125 is merged. |
|
Can you please rebase with the latest changes from master |
meganemura
force-pushed
the
remove-blank-line
branch
from
fa42024
to
965fb1f
Compare
|
rebased and test passed 🎉 |
|
Thank you! @bundlerbot r+ |
|
📌 Commit 965fb1f has been approved by |
Remove a blank line in generated gemspec for RUBY_VERSION >= "2.0.0"
### What was the end-user problem that led to this PR?
Need to remove a leading blank line of generated gemspec.
### What was your diagnosis of the problem?
```erb
<%- if RUBY_VERSION < "2.0.0" -%>
# coding: utf-8
<%- end -%>
lib = File.expand_path("../lib", __FILE__)
...
```
When executing `bundle gem xxx` with ruby (< 2.0), the leading blank line is appeared.
### What is your fix for the problem, implemented in this PR?
Move a blank line into the `if` block.
### Why did you choose this fix out of the possible options?
😃
|
☀️ Test successful - status-travis |
What was the end-user problem that led to this PR?
Need to remove a leading blank line of generated gemspec.
What was your diagnosis of the problem?
When executing
bundle gem xxxwith ruby (< 2.0), the leading blank line is appeared.What is your fix for the problem, implemented in this PR?
Move a blank line into the
ifblock.Why did you choose this fix out of the possible options?
😃