This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
[bundle add] Add version prefix flexibility #6556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrim123
force-pushed
the
agr-versions-gem-add
branch
from
323fd2a
to
ec36d07
Compare
segiddins
reviewed
May 28, 2018
lib/bundler/cli.rb
Outdated
| @@ -335,6 +335,8 @@ def binstubs(*gems) | |||
| method_option "source", :aliases => "-s", :type => :string | |||
| method_option "skip-install", :type => :boolean, :banner => | |||
| "Adds gem to the Gemfile but does not install it" | |||
| method_option "optimistic", :type => :boolean | |||
| end | ||
| end | ||
|
|
||
| describe "with --strict option" do |
There was a problem hiding this comment.
should we error when passing both --optimistic and --strict ?
|
If I specify version then a strict declaration is added and these options have no affect. Should we disable the use of these options when version is specified? or inco-oporate these flags with the version also? |
|
I think it’s fine to allow the specific requirement given to override the flags? |
|
But if we provide flexibility then I think we should allow 🤔 , any side effects for this? |
colby-swandale
changed the title
For what ? |
|
I meant something like this bundle add rack --version=1.1 --optimisticThis would do something like this gem "rack", ">= 1.1"Or a few more commands like |
segiddins
approved these changes
Jun 4, 2018
|
Great! This looks amazing! @bundlerbot r+ |
|
📌 Commit 9250dbc has been approved by |
bundlerbot
added a commit
that referenced
this pull request
Jun 6, 2018
[bundle add] Add version prefix flexibility ### What was the end-user problem that led to this PR? By default, on `bundle add` we use "pessimistic" way (~>) of versions. According to this [comment](https://github.com/bundler/bundler/issues/6553#issue-326023952) some users face problems. ### What was your diagnosis of the problem? Adding flags to provide flexibility to change this declaration namely `optimistic` and `strict` ### What is your fix for the problem, implemented in this PR? Adding flags to opt for other declarations. ### Why did you choose this fix out of the possible options? Currently, its an experiment and I have added it to only `bundle add` but still the version locked in lockfile are "pessimistic". Need suggestions on this and on how to proceed. Addresses #6553
|
☀️ Test successful - status-travis |
This was referenced Jun 6, 2018
colby-swandale
pushed a commit
that referenced
this pull request
Sep 21, 2018
[bundle add] Add version prefix flexibility ### What was the end-user problem that led to this PR? By default, on `bundle add` we use "pessimistic" way (~>) of versions. According to this [comment](https://github.com/bundler/bundler/issues/6553#issue-326023952) some users face problems. ### What was your diagnosis of the problem? Adding flags to provide flexibility to change this declaration namely `optimistic` and `strict` ### What is your fix for the problem, implemented in this PR? Adding flags to opt for other declarations. ### Why did you choose this fix out of the possible options? Currently, its an experiment and I have added it to only `bundle add` but still the version locked in lockfile are "pessimistic". Need suggestions on this and on how to proceed. Addresses #6553 (cherry picked from commit 43b4fa9)
colby-swandale
pushed a commit
that referenced
this pull request
Sep 22, 2018
[bundle add] Add version prefix flexibility ### What was the end-user problem that led to this PR? By default, on `bundle add` we use "pessimistic" way (~>) of versions. According to this [comment](https://github.com/bundler/bundler/issues/6553#issue-326023952) some users face problems. ### What was your diagnosis of the problem? Adding flags to provide flexibility to change this declaration namely `optimistic` and `strict` ### What is your fix for the problem, implemented in this PR? Adding flags to opt for other declarations. ### Why did you choose this fix out of the possible options? Currently, its an experiment and I have added it to only `bundle add` but still the version locked in lockfile are "pessimistic". Need suggestions on this and on how to proceed. Addresses #6553 (cherry picked from commit 43b4fa9)
colby-swandale
pushed a commit
that referenced
this pull request
Oct 5, 2018
[bundle add] Add version prefix flexibility ### What was the end-user problem that led to this PR? By default, on `bundle add` we use "pessimistic" way (~>) of versions. According to this [comment](https://github.com/bundler/bundler/issues/6553#issue-326023952) some users face problems. ### What was your diagnosis of the problem? Adding flags to provide flexibility to change this declaration namely `optimistic` and `strict` ### What is your fix for the problem, implemented in this PR? Adding flags to opt for other declarations. ### Why did you choose this fix out of the possible options? Currently, its an experiment and I have added it to only `bundle add` but still the version locked in lockfile are "pessimistic". Need suggestions on this and on how to proceed. Addresses #6553 (cherry picked from commit 43b4fa9)
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
By default, on
bundle addwe use "pessimistic" way (~>) of versions. According to this comment some users face problems.What was your diagnosis of the problem?
Adding flags to provide flexibility to change this declaration namely
optimisticandstrictWhat is your fix for the problem, implemented in this PR?
Adding flags to opt for other declarations.
Why did you choose this fix out of the possible options?
Currently, its an experiment and I have added it to only
bundle addbut still the version locked in lockfile are "pessimistic". Need suggestions on this and on how to proceed.Addresses #6553