Enable gemfile flag for bundle lock #6748
Conversation
|
Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack. For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide |
|
@bundlerbot r+ |
6748: Enable gemfile flag for bundle lock r=colby-swandale a=jekuta ### What was the end-user problem that led to this PR? `bundle lock` does not accept the `--gemfile` flag that allows to define a custom Gemfile. ### What was your diagnosis of the problem? The option is not defined as available. ### What is your fix for the problem, implemented in this PR? Adds the option to the list available options for `lock` command. I wasn't sure though, in which order to display this the new option. I just added it where it felt the most natural to me, but please let me know if there is a better order. Also do you think it would make sense to add this flag to the other commands as well? For example: `add`, `remove`, `console`, `outdated`, `clean`? For now it is available for: `check`, `exec`, `install`, `update`, `package`, `doctor`. ### Why did you choose this fix out of the possible options? I don't think there are any other options to implement this. Closes #6735 Co-authored-by: Laura Paakkinen <[email protected]>
Yes! it would be great if we could make the UI consistent across the commands that operate on the Gemfile |
Build succeeded |
ghost
merged commit 
What was the end-user problem that led to this PR?
bundle lockdoes not accept the--gemfileflag that allows to define a custom Gemfile.What was your diagnosis of the problem?
The option is not defined as available.
What is your fix for the problem, implemented in this PR?
Adds the option to the list available options for
lockcommand.I wasn't sure though, in which order to display this the new option. I just added it where it felt the most natural to me, but please let me know if there is a better order.
Also do you think it would make sense to add this flag to the other commands as well?
For example:
add,remove,console,outdated,clean?For now it is available for:
check,exec,install,update,package,doctor.Why did you choose this fix out of the possible options?
I don't think there are any other options to implement this.
Closes #6735