Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Fix BUNDLE_PATH_RELATIVE_TO_CWD env variable name #6751

Merged
1 commit merged into from
Oct 23, 2018
Merged

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user problem that led to this PR?

The problem was that an environment variable in the docs does not work.

What was your diagnosis of the problem?

My diagnosis was that its name is incorrect.

What is your fix for the problem, implemented in this PR?

My fix is to fix the typo.

Why did you choose this fix out of the possible options?

I chose this fix because it's the only non absurd fix.

@colby-swandale
Copy link
Member

Thanks for picking this up!

1 similar comment
@colby-swandale
Copy link
Member

Thanks for picking this up!

@colby-swandale
Copy link
Member

@bundlerbot r+

1 similar comment
@colby-swandale
Copy link
Member

@bundlerbot r+

@deivid-rodriguez
Copy link
Member Author

It sounds like Github needs a break :)

@greysteil
Copy link
Contributor

GitHub isn't sending webhooks, so we won't be able to use bundlerbot for the moment.

@deivid-rodriguez
Copy link
Member Author

Yeah, I guess everyone has noticed by now 😅. It's amazing how tightly we depend on certain services 😮.

@deivid-rodriguez
Copy link
Member Author

@bundlerbot r=greysteil

ghost pushed a commit that referenced this pull request Oct 23, 2018
6751: Fix BUNDLE_PATH_RELATIVE_TO_CWD env variable name r=greysteil a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that an environment variable in the docs does not work.

### What was your diagnosis of the problem?

My diagnosis was that its name is incorrect.

### What is your fix for the problem, implemented in this PR?

My fix is to fix the typo.

### Why did you choose this fix out of the possible options?

I chose this fix because it's the only non absurd fix.


Co-authored-by: David Rodríguez <[email protected]>
@ghost
Copy link

ghost commented Oct 23, 2018

Build succeeded

@ghost ghost merged commit d884ec8 into master Oct 23, 2018
@deivid-rodriguez deivid-rodriguez deleted the fix_env_variable_name branch October 23, 2018 22:00
@colby-swandale colby-swandale added this to the 2.0.2 milestone Feb 25, 2019
colby-swandale pushed a commit that referenced this pull request Mar 23, 2019
6751: Fix BUNDLE_PATH_RELATIVE_TO_CWD env variable name r=greysteil a=deivid-rodriguez

### What was the end-user problem that led to this PR?

The problem was that an environment variable in the docs does not work.

### What was your diagnosis of the problem?

My diagnosis was that its name is incorrect.

### What is your fix for the problem, implemented in this PR?

My fix is to fix the typo.

### Why did you choose this fix out of the possible options?

I chose this fix because it's the only non absurd fix.


Co-authored-by: David Rodríguez <[email protected]>
(cherry picked from commit c24e8f5)
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 18, 2019
## 2.0.2 (2019-05-13)

Changes:

  - Fixes for Bundler integration with ruby-src ([#6941](rubygems/bundler#6941), [#6973](rubygems/bundler#6973), [#6977](rubygems/bundler#6977), [#6315](rubygems/bundler#6315), [#7061](rubygems/bundler#7061))
  - Use `__dir__` instead of `__FILE__` when generating a gem with `bundle gem` ([#6503](rubygems/bundler#6503))
  - Use `https` on externals links in the Bundler gemspec ([#6721](rubygems/bundler#6721))
  - Removed duplicate gem names from the suggested `did you mean` list for gem typos ([#6739](rubygems/bundler#6739))
  - Removed Ruby 1.x compatibility code ([#6764](rubygems/bundler#6764), [#6806](rubygems/bundler#6806))
  - Fixed an issue where `bundle remove` would crash with certain Gemfiles ([#6768](rubygems/bundler#6769))
  - Fixed indentation in the Bundler executable template ([#6773](rubygems/bundler#6773))
  - Fixed an issue where plugins could register for the same Bundler hook multiple times ([#6775](rubygems/bundler#6775))
  - Changed the "multiple sources" message in `bundle install` to be a warning instead of an error ([#6790](rubygems/bundler#6790))
  - Fixed a bug where path gems would break when using `only_update_to_newer_versions` ([#6774](rubygems/bundler#6774))
  - Fixed a bug where installing plugins with the `--delpoyment` setting would fail ([#6805](rubygems/bundler#6805))
  - Fixed an issue where `bundle update` couldn't update & install a gem when `no_install` was set (a `bundle package` config) ([#7078](rubygems/bundler#7078))
  - Fixed an issue where users could not run `bundle exec` on default gems ([#6963](rubygems/bundler#6963))
  - Updated vendor libraries to their latest version ([#7076](rubygems/bundler#7067), [#7068](rubygems/bundler#7068))
  - Fixed an issue where the `github` source was not using `https` by default that we mentioned in the 2.0 release ([#7182](rubygems/bundler#7182))
  - Fixed an issue where `rake release` was not outputting the message to users asking for a 2fa token ([#7199](rubygems/bundler#7199))

Documentation:

  - Fix incorrect documented `BUNDLE_PATH_RELATIVE_TO_CWD` env var ([#6751](rubygems/bundler#6751))
  - Update URLs in Bundler's documentation to use `https` ([#6935](rubygems/bundler#6935))

## 2.0.1 (2019-01-04)

Changes:

  - Relaxed RubyGems requirement to `>= 2.5.0` ([#6867](rubygems/bundler#6867))

## 2.0.0 (2019-01-03)

No new changes

## 2.0.0.pre.3 (2018-12-30)

Breaking Changes:

  - Bundler 2 now requires RubyGems 3.0.0 at minimum

Changes:

  - Ruby 2.6 compatibility fixes (@segiddins)
  - Import changes from Bundler 1.17.3 release

Note: To upgrade your Gemfile to Bundler 2 you will need to run `bundle update --bundler`

## 2.0.0.pre.2 (2018-11-27)

Breaking Changes:

  - `:github` source in the Gemfile now defaults to using HTTPS

Changes

  - Add compatibility for Bundler merge into ruby-src

Note: To upgrade your Gemfile to Bundler 2 you will need to run `bundle update --bundler`

## 2.0.0.pre.1 (2018-11-09)

Breaking Changes:

  - Dropped support for versions of Ruby < 2.3
  - Dropped support for version of RubyGems < 2.5
  - Moved error messages from STDOUT to STDERR

Note: To upgrade your Gemfile to Bundler 2 you will need to run `bundle update --bundler`
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants