Added quiet flag to inline bundler #6828
Conversation
|
Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack. For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide |
|
This PR will need a test before we will consider merging it. |
|
👍 I'm on it! |
|
How do You like it now @colby-swandale ? |
lib/bundler/inline.rb
Outdated
| @@ -36,6 +36,7 @@ def gemfile(install = false, options = {}, &gemfile) | |||
|
|
|||
| opts = options.dup | |||
| ui = opts.delete(:ui) { Bundler::UI::Shell.new } | |||
| ui.level = "silent" if opts.delete(:quiet) { false } | |||
There was a problem hiding this comment.
We don't need to set a default value here.
spec/runtime/inline_spec.rb
Outdated
| RUBY | ||
|
|
||
| expect(out).to be_empty | ||
| expect(exitstatus).to be_zero if exitstatus |
There was a problem hiding this comment.
This assertion can be removed, this test only cares about the quiet flag.
|
|
|
Looks great! Thank you! @bundlerbot r+ |
6828: Added quiet flag to inline bundler r=colby-swandale a=ipepe Thanks so much for the contribution! To make reviewing this PR a bit easier, please fill out answers to the following questions. ### What was the end-user problem that led to this PR? I'm using inline bundler on my CI minitest file. I wanted to make it quiet so output is clean and meaningful. ### What was your diagnosis of the problem? Bundler inline's gemfile method only accepted :ui option. ### What is your fix for the problem, implemented in this PR? I added quiet option flag to gemfile method. ### Why did you choose this fix out of the possible options? I chose this fix because it looked simple and clean. Co-authored-by: Patryk Ptasiński <[email protected]>
|
Thank You |
Build succeeded |
ghost
merged commit 
Thanks so much for the contribution!
To make reviewing this PR a bit easier, please fill out answers to the following questions.
What was the end-user problem that led to this PR?
I'm using inline bundler on my CI minitest file. I wanted to make it quiet so output is clean and meaningful.
What was your diagnosis of the problem?
Bundler inline's gemfile method only accepted :ui option.
What is your fix for the problem, implemented in this PR?
I added quiet option flag to gemfile method.
Why did you choose this fix out of the possible options?
I chose this fix because it looked simple and clean.