This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Shellsplit build config #7023
Merged
Shellsplit build config #7023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
approved these changes
Mar 8, 2019
|
Might be nice to have stored these args as an array in the first place, too! With backward compatibility support for single-string build args. Separate PR though, I imagine. For this PR, could broaden test coverage in |
deivid-rodriguez
force-pushed
the
shellsplit_build_config
branch
from
23464a7
to
70cb2f0
Compare
|
I added the suggested spec, sorry for the delay! |
|
Feedback was addressed and @hsbt already approved the initial version, so going in! @bundlerbot r+ |
ghost
pushed a commit
that referenced
this pull request
Apr 4, 2019
7023: Shellsplit build config r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was #6940. Build configurations with multiple whitepaced parameter are no longer properly handled. ### What was your diagnosis of the problem? My diagnosis was not mine, was @jeremy's: Since [shellscaping / shelljoining build arguments to the rubygems gem installer](#6940), these are no longer properly passed ### What is your fix for the problem, implemented in this PR? My fix is not mine, it's @jeremy's: shellsplit settings before passing them. ### Why did you choose this fix out of the possible options? I chose this fix because it works and it sounds like the proper followup to rubygems/rubygems#2441. Fixes #6940. Co-authored-by: David Rodríguez <[email protected]>
Build succeeded |
ghost
merged commit 
1 task
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user problem that led to this PR?
The problem was #6940. Build configurations with multiple whitepaced parameter are no longer properly handled.
What was your diagnosis of the problem?
My diagnosis was not mine, was @jeremy's: Since shellscaping / shelljoining build arguments to the rubygems gem installer, these are no longer properly passed
What is your fix for the problem, implemented in this PR?
My fix is not mine, it's @jeremy's: shellsplit settings before passing them.
Why did you choose this fix out of the possible options?
I chose this fix because it works and it sounds like the proper followup to rubygems/rubygems#2441.
Fixes #6940.