Bundler displays a duplicate gem entries warning even if gems only appear once per group

[davidstosik]

What was the end-user problem that led to this PR?

I have a Gemfile where some gems appear in two distinct groups. When I run Bundle, the following warning is displayed:

Your Gemfile lists the gem #{gem} more than once.
You should probably keep only one of them.
Remove any duplicate entries and specify the gem only once (per group).
While it's not a problem now, it could cause errors if you change the version of one of them later.

Example Gemfile:

source "https://rubygems.org"

group :production do
end

group :development do
  gem "rake"
end

group :ci, optional: true do
  gem "rake"
end

What was your diagnosis of the problem?

I think the message is misleading, because it shows even if all gems are specified only once per group.

What is your fix for the problem, implemented in this PR?

I removed the (per group) mention from the warning message in order to prevent confusion.

Why did you choose this fix out of the possible options?

I chose this fix because it was the simplest way to bring your attention to the problem.

If Bundler's real intent is to allow the same gem to appear in multiple groups, as long as it does not appear more than once per group, then my suggestion is wrong, and instead, the logic around the warning message needs to be fixed.

[welcome]

Thanks for opening a pull request and helping make Bundler better! Someone from the Bundler team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use Travis CI to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of Travis CI in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #bundler channel on Slack.

For more information about contributing to the Bundler project feel free to review our CONTRIBUTING guide

[davidstosik]

Note that while Bundler raises this warning, I can fix my Gemfile this way:

source "https://rubygems.org"

group :production do
end

group :development, :ci do
  gem "rake"
end

group :ci, optional: true do
end

(In reality I have more gems, some only for CI, some only for development.)

[deivid-rodriguez]

Yeah, my guess is that this is to not give the false impression that bundler supports separate resolutions per group, and that you can specify separate (possibly incompatible) dependencies for the same gem in different groups.

So, to me, this PR is good 👍.

[hsbt]

@bundlerbot r+

[ghost]

Build succeeded

• continuous-integration/travis-ci/push