-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gemspec: Exclude *.bundle (follow-up #281) #285
Conversation
I've done some tests on my end... interestingly I see no change in behavior with the commits on this branch. |
I think that the clean & clobber tasks were not properly cleaning up everything. I added |
Not sure I follow 100%: For me it's always |
this is great, thanks. |
Follow-Up for #281
Addresses #283 (comment)
I don't quite fully understand why this breaks, but building locally using
bundle exec rake compile
broke with #281. It works fine in CI though, which might be worth investigating. What worked for me to fix this (please have a look @Fayti1703) is to make sure*.bundle
files are excluded. With thisbundle install && bundle exec rake
works (compiles and runs tests).My experience with native extensions is limited. I'd appreciate hints how to make local compilation consistent with CI.
-cc @Fayti1703
-cc @lloeki