-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow serializing JSON directly to a stream. #34
base: master
Are you sure you want to change the base?
Conversation
How about with |
Right, I forgot to mention that it only works with character streams, and octets t overrides it. Actually, I just thought of a way to add support for octet streams without too much effort, I'll add that to this pull request. |
I won't merge any PRs without tests. :( And, it's better to me to rename keyword |
And, I saw PR in fast-io. |
19be13a
to
4530fc9
Compare
Also changed keyword argument from :stream to :output.
4530fc9
to
ff0a08e
Compare
Hmmm, I need to update compile-encoder and the compiler macro as well. |
I played around with it for a while, but eventually realized that the evals execute the code in a null lexical environment, which makes it difficult to capture the output stream. If you have any ideas on how to get compile-encoder to work with an output stream I would be happy to help implement it. |
1f13f8d
to
f28095d
Compare
No description provided.