Skip to content

Commit

Permalink
[core] Fix the redis issue with TLS/SSL in AWS Redis (ray-project#29244)
Browse files Browse the repository at this point in the history
When connecting to secured redis sometimes config is not allowed (https://redis.io/docs/manual/security/) by default for security reasons by the vendor.

In Ray, Redis used to be used for pubsub, but not anymore. This PR just deletes this config setup so that it can be used with vendor's redis.
  • Loading branch information
fishbone authored Oct 12, 2022
1 parent 75e9722 commit 223ce39
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions src/ray/gcs/redis_context.cc
Original file line number Diff line number Diff line change
Expand Up @@ -428,14 +428,8 @@ Status RedisContext::Connect(const std::string &address,
RAY_CHECK(redisInitiateSSLWithContext(context_, ssl_context_) == REDIS_OK)
<< "Failed to setup encrypted redis: " << context_->errstr;
}

RAY_CHECK_OK(AuthenticateRedis(context_, password));

redisReply *reply = reinterpret_cast<redisReply *>(
redisCommand(context_, "CONFIG SET notify-keyspace-events Kl"));
REDIS_CHECK_ERROR(context_, reply);
freeReplyObject(reply);

// Connect to async context
redisAsyncContext *async_context = nullptr;
RAY_CHECK_OK(ConnectWithRetries(address, port, redisAsyncConnect, &async_context));
Expand Down

0 comments on commit 223ce39

Please sign in to comment.