Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Cache npm dependencies #6033

Merged
merged 1 commit into from
Jan 12, 2022
Merged

ci: Cache npm dependencies #6033

merged 1 commit into from
Jan 12, 2022

Conversation

relrelb
Copy link
Contributor

@relrelb relrelb commented Jan 12, 2022

This should improve CI build times.

Done as described in:
https://github.com/actions/setup-node#caching-packages-dependencies

@adrian17
Copy link
Collaborator

Do you think we could also cache built cargo dependencies - or at least wasm-bindgen binary? Because apparently cargo install wasm-bindgen-cli --version 0.2.78 alone takes 6-9m on windows machines.

@Herschel
Copy link
Member

Herschel commented Jan 12, 2022

Caching wasm-bindgen binary should be a big help and straightforward.
Caching Rust dependencies is trickier because it's difficult to to differentiate things in the target folder, see: rust-lang/cargo#5885 rust-lang/cargo#7150
Worth investigating https://github.com/marketplace/actions/rust-cache , but this looks like it also just uploads target so may run afoul of the above issue.

Copy link
Member

@Herschel Herschel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Herschel Herschel merged commit c4d013c into ruffle-rs:master Jan 12, 2022
@relrelb relrelb deleted the npm_cache branch January 12, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants