Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare 7.1.0 release #1871

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Prepare 7.1.0 release #1871

merged 1 commit into from
Feb 15, 2021

Conversation

deguif
Copy link
Collaborator

@deguif deguif commented Nov 16, 2020

No description provided.

@deguif deguif force-pushed the prepare-71-release branch from 969039c to 4a6e297 Compare November 16, 2020 14:03
ruflin
ruflin approved these changes Nov 18, 2020
View reviewed changes
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you check if there are also any changes we need to make to the README.md file?

Here is my release checklist: https://elastica.io/release/how-to-create-an-elastica-release.html

I normally update also Elastica.io with the most recent docs, I can take care of that after the release.

@deguif
Copy link
Collaborator Author

deguif commented Nov 18, 2020

@ruflin I think we could wait for the Elasticsearch official library to support PHP 8.0 before releasing 7.1.0. WDYT?

@ezimuel commented recently on elastic/elasticsearch-php#1063 so I'm hoping support for PHP 8.0 there will be shipped soon.

@ruflin
Copy link
Owner

ruflin commented Nov 18, 2020

++ on waiting for the official client to support 8.0.

Lets make sure we rebase than again as the changelog will contain many more things :-D

@deguif deguif force-pushed the prepare-71-release branch from 4a6e297 to 6423ed8 Compare December 3, 2020 12:28
@ruflin
Copy link
Owner

ruflin commented Dec 3, 2020

Let me know when this is ready and I should have another look. Lots has happened since this got opened :-D

@dakorpar dakorpar mentioned this pull request Dec 14, 2020
Merged
@deguif deguif mentioned this pull request Feb 3, 2021
Closed
@ruflin
Copy link
Owner

ruflin commented Feb 4, 2021

@deguif I see a few of the referenced PR's merged. Is this still blocked?

@jmsche
Copy link

jmsche commented Feb 11, 2021

elasticsearch-php 7.11.0 was released today with PHP 8 support, maybe this can unlock the release here?

@deguif
Copy link
Collaborator Author

deguif commented Feb 11, 2021

Yes, let's release here ;)

@deguif deguif force-pushed the prepare-71-release branch 2 times, most recently from e2da3ac to 6955899 Compare February 11, 2021 13:23
@deguif deguif force-pushed the prepare-71-release branch from 6955899 to 24eced9 Compare February 11, 2021 13:40
@deguif
Copy link
Collaborator Author

deguif commented Feb 11, 2021

@ruflin could you have a look to the changelog now that it's ready to publish.

@Korbeil Korbeil mentioned this pull request Feb 13, 2021
Closed
ruflin
ruflin approved these changes Feb 15, 2021
View reviewed changes
Copy link
Owner

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deguif deguif mentioned this pull request Feb 15, 2021
Merged
@deguif deguif merged commit ec22ea0 into ruflin:master Feb 15, 2021
@deguif deguif deleted the prepare-71-release branch February 15, 2021 10:32
@deguif deguif self-assigned this Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@deguif deguif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deguif @ruflin @jmsche