Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed argument name in vector_store/supabase #7103

Merged
merged 5 commits into from
Aug 13, 2023

Conversation

Moi1oM
Copy link
Contributor

@Moi1oM Moi1oM commented Aug 1, 2023

Description

I was trying to do a vector store using llama index and supabase, but the following error occurred. "TypeError: Collection.upsert() got an unexpected keyword argument 'vectors'." So I changed the named arguments from vectors to records and ran the code, and it worked properly. And collection. Among the named arguments in query, query_vector was replaced with data. The Dependency has not changed.

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

The only part I changed was the argument, so I didn't write a new test.

  • Added new unit/integration tests
  • Added new notebook (that tests end-to-end)
  • I stared at the code and made sure it makes sense

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Disiok
Copy link
Collaborator

Disiok commented Aug 11, 2023

Hmm, this is surprising. The official docs seem to suggest otherwise: https://supabase.com/docs/guides/ai/vecs-python-client

Curious where did you get the keyword args from?

@Moi1oM
Copy link
Contributor Author

Moi1oM commented Aug 11, 2023

Hmm, this is surprising. The official docs seem to suggest otherwise: https://supabase.com/docs/guides/ai/vecs-python-client

Curious where did you get the keyword args from?

https://gpt-index.readthedocs.io/en/latest/examples/vector_stores/SupabaseVectorIndexDemo.html

I was just following the code of this link docs and got an argument error

Here's the colab link that reproduced when I encountered an error

https://colab.research.google.com/drive/195Dk4T9iB-thLj5g3lEWa_gCKyoo5IT5?usp=sharing

@logan-markewich
Copy link
Collaborator

@Disiok the vecs Readme seems to reflect this? It was updated two weeks ago
supabase/vecs@43b73fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants