Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Host Functions #18

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Storage Host Functions #18

merged 6 commits into from
Aug 2, 2024

Conversation

bbyalcinkaya
Copy link
Member

@bbyalcinkaya bbyalcinkaya commented Aug 1, 2024

This PR implements the following storage host functions:

  1. put_contract_data
  2. has_contract_data
  3. get_contract_data

Note: Stellar has a state archival model for contracts and storage data, where users need to pay rent to store data for a given TTL. For now, we ignored this in the semantics; all data have infinite TTL and storing data is free.
See:

@bbyalcinkaya bbyalcinkaya marked this pull request as ready for review August 1, 2024 11:20
Copy link

@dkcumming dkcumming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I am a little unfamiliar with the names of some of the functions and cells, so I am not giving a very critical review. Maybe we should get on another call sometime next week and I can ask some questions and be a more useful reviewer!

@rv-jenkins rv-jenkins merged commit 4bb7100 into master Aug 2, 2024
3 checks passed
@rv-jenkins rv-jenkins deleted the storage branch August 2, 2024 09:25
@bbyalcinkaya bbyalcinkaya mentioned this pull request Aug 20, 2024
asavienko added a commit that referenced this pull request Sep 4, 2024
* copy kontrol version of landing page

* update lock

* format

* remove dead code

* up lock

* changes to home page, content and animation

* various fixes

* add collaborator

* fix contact us
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants