-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement binary for accuracy testing #16
base: main
Are you sure you want to change the base?
Conversation
What is the status of this PR? |
At a glance:
|
I agree about the CLI parameters for image paths
I also agree with this change
As intermediate goal, we can produce images which are equals to the one created with |
I am not sure if I understand you correctly. The original goal was to
The big question is: What to use as a reference? I used
I don't really know enough about imagemagick (or possible alternatives) to solve this without some significant time investment. |
Ok now I better see the problem, thanks! Can we use the test card as minimal case in order to isolate where deltas are? For example, if we have 3 frameworks, we can pass the I do not know if this procedure is feasible or if I've figured out correctly the issue. |
I had the idea a while ago, but never really got around to implementing it. I'm PRing in the current state to get some feedback, as I'm not 100% sure on where to take this and how to make it more useful.
One of the biggest questions is how to properly test the algorithm accuracy. So far, I've tried converting the source (sRGB) image with imagemagick via
convert pic_srgb.png -colorspace RGB pic_rgb.png
. But when comparing the converted image to aLinearRgb
conversion (current code), you'll see that the error is relatively large (and that even turning fastmath off won't help much). Not sure what's going on there.Run with
cargo run --features build-acctest --bin acctest -r