refactor: check the node syntax before size limit #747
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m not 100% sure if it’s intended, but the behavior of
check_global_consensus_validity
, which checks the script size limit first and then node could confuse the user-side.For example, If
sh
orwsh
descriptor usesmulti_a
with 999 public key(e.g.descriptor::Wsh::from_str("wsh(multi_a(pk1...pk999)")
), it will throw an error on the size limit, not the fragmentmulti_a
. It might be a bit more efficient in case of size overflow, butcheck_global_consensus_validity
, Syntax of which validity differ on context(e.g.multi
andmulti_a
) are not.While descriptor itself is kinda helper tool which uses miniscript, it would worth checking syntax first.