Fix decoding of WIF with BIP32 origin #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shesek
force-pushed
the
202410-fix-wif-fromstr
branch
from
6e4d0ed to
aa218ef
Compare
shesek
force-pushed
the
202410-fix-wif-fromstr
branch
from
aa218ef to
9416098
Compare
shesek
added a commit
to shesek/minsc
that referenced
this pull request
Oct 17, 2024
This uncovered a bug in rust-miniscript causing the origin information to be lost, so it will not actually work until the fix is merged: rust-bitcoin/rust-miniscript#753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix for a small oversight.
The test has to pattern match the inner
SinglePrivbecause there's no other way to get derivation path (nofull_derivation_path(s)method likeDescriptorPublicKeyhas, which would be nice to have ^.^)