Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzz: add target for Descriptor::parse_descriptor #787

Merged

Conversation

brunoerg
Copy link
Contributor

No description provided.

@brunoerg brunoerg force-pushed the 2024-12-fuzz-descriptor-parse-priv branch from 38a578d to a9d9cdc Compare December 23, 2024 18:20
@apoelstra
Copy link
Member

Looks like CI is failing because of clippy:

  --> fuzz/fuzz_targets/parse_descriptor_priv.rs:11:57
   |
11 |     if let Ok((desc, _)) = Descriptor::parse_descriptor(&secp, &data_str) {
   |                                                         ^^^^^ help: change this to: `secp`
   |

@brunoerg brunoerg force-pushed the 2024-12-fuzz-descriptor-parse-priv branch from a9d9cdc to eb1e9f6 Compare December 23, 2024 19:36
@brunoerg
Copy link
Contributor Author

@apoelstra thanks, fixed!

Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK eb1e9f6

Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK eb1e9f6; successfully ran local tests; thanks!

@apoelstra apoelstra merged commit a17b34c into rust-bitcoin:master Dec 24, 2024
30 checks passed
@brunoerg brunoerg deleted the 2024-12-fuzz-descriptor-parse-priv branch December 25, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants