Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default terminal size to 80x25 #17

Closed
wants to merge 1 commit into from

Conversation

tailhook
Copy link

It looks like otherwise the default is 0, which crashes some programs.

I would make it customizable, but I'm not sure how to make API for that.

Also see #10

@philippkeller
Copy link
Collaborator

thanks for the PR @tailhook and sorry that I didn't respond so far. I'm giving this project some love again, and would like to also look into this PR and maybe a way to customize the terminal size.

I'd like to play with it, what's your use case? or asked differently: what program crashes currently without the terminal size?

@tailhook
Copy link
Author

I'd like to play with it, what's your use case? or asked differently: what program crashes currently without the terminal size?

This is the crash: https://github.com/edgedb/edgedb-cli/runs/666845514?check_suite_focus=true
Note, the crash is actually in rustyline library. And that may involve some PR which isn't yet landed into a master.

Now as I'm thinking about it more, maybe it's better to fix rustyline to treat that as "infinite width". But being able to specify terminals size in rexpect makes sense anyway.

@tailhook
Copy link
Author

Also see this this thread on the similar issue: containers/podman#351

@matthiasbeyer
Copy link
Member

Hi! I am closing this PR now as it seems to be no longer relevant to you. Feel free to open a new one if you're still running into issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants