Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a 2D VolBlock equivalent #29

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

nicopap
Copy link
Contributor

@nicopap nicopap commented Sep 26, 2022

Closes #27

Note the get_column impl block is commented out because
it requires unstable features. Though in practice, get_row is
the most important.

@Lokathor
Copy link
Member

Looks like you'll maybe have to raise the CI MSRV some? I'm shocked that we didn't already have a panic in a const fn somewhere in the crate, but maybe we only ever had const-if instead.

@nicopap
Copy link
Contributor Author

nicopap commented Sep 27, 2022

Looks like const_panic was stabilized on 1.57, just one version short of the voladdress current MSRV, let's see if bumping it works rust-lang/rust#89508

@Lokathor Lokathor merged commit a100d0f into rust-console:main Sep 27, 2022
@Lokathor
Copy link
Member

I released voladdress-1.1, which adds a small method for converting addresses of arrays into blocks, but also includes this PR behind another "experimental" flag. I suspect things are totally fine, but I'd rather have it be opt-in for a while just in case.

@nicopap
Copy link
Contributor Author

nicopap commented Oct 1, 2022

Thank you for the blazing fast response and merge. I wasn't expecting such velocity.

@nicopap nicopap deleted the volmatrix branch August 30, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2d Voladdress type
2 participants