-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version bump and release? #9
Comments
I haven't really tested the community contributions. So mileage may vary
for 'stable' in a non production version.
I believe most people are using it from git.
That being said, I am happy to release a new version of it helps. The
changes shouldn't really be all that incompatible.
…On Fri, 6 May 2022, 01:40 Alex Norman, ***@***.***> wrote:
Is the code as is stable enough for a new release? I see that crates.io
has usbd-midi 0.2.0 but that version doesn't have the midi read support
that is in the main branch here..
—
Reply to this email directly, view it on GitHub
<#9>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACAGFMR4Z2K7JC4UJR4IH3VIQBY3ANCNFSM5VFY4IEQ>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I'm able to use it from git too but was initially a little confused when the example on the front page didn't work with what I had installed via |
Ah yeah I guess some of the prs didn't update the doc.
Honestly I am not super actively developing this. It was used in a device
that is completed, which I don't need new firmware for, but I am happy to
maintain and help others.
In regards to the example. If you could update it a PR that would be great.
From there I will publish it to crates to help any other newcomers.
…On Fri, 6 May 2022, 07:35 Alex Norman, ***@***.***> wrote:
I'm able to use it from git too but was initially a little confused when
the example on the front page didn't work with what I had installed via
crates.io .. not uncommon with rust projects, nice that it is so easy.
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACAGFO6SLZLOYPUNAAWJ6LVIRLNBANCNFSM5VFY4IEQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Hey @btrepp .. I am willing/interested to take this crate over and migrate it over to https://github.com/rust-midi/ I have a PR #11 up here that integrates the shared midi type/conversion code that @mendelt and I have been collaborating on and also have a re-org/simplification staged that I believe addresses the concerns of the previous #10 draft request. If you want to take a look at #11 I'd be happy for that but if you're just wanting to hand off the project I'd fork it over to |
I've had a look at #11 and am happy with it, just have a suggestion for the breaking change aspect and it's good to go. I'm happy for it to be moved into rust-midi. It's logical to sit inside a broader ecosystem, and will make it easier to use and align the types. I've added you as a collaborator to this repo to help facilitate this. |
Hey @btrepp .. I'm not 100% sure what you intended by adding me as a collaborator. I'm not able to initiate a transfer to I could simply fork over to |
Version 0.3.0 was just released on crates.io. |
Is the code as is stable enough for a new release? I see that crates.io has
usbd-midi 0.2.0
but that version doesn't have the midi read support that is in the main branch here..The text was updated successfully, but these errors were encountered: