Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version bump and release? #9

Closed
x37v opened this issue May 5, 2022 · 7 comments
Closed

version bump and release? #9

x37v opened this issue May 5, 2022 · 7 comments

Comments

@x37v
Copy link
Collaborator

x37v commented May 5, 2022

Is the code as is stable enough for a new release? I see that crates.io has usbd-midi 0.2.0 but that version doesn't have the midi read support that is in the main branch here..

@btrepp
Copy link
Collaborator

btrepp commented May 5, 2022 via email

@x37v
Copy link
Collaborator Author

x37v commented May 5, 2022

I'm able to use it from git too but was initially a little confused when the example on the front page didn't work with what I had installed via crates.io .. not uncommon with rust projects, nice that it is so easy.

@btrepp
Copy link
Collaborator

btrepp commented May 6, 2022 via email

@x37v
Copy link
Collaborator Author

x37v commented Dec 1, 2022

Honestly I am not super actively developing this. It was used in a device that is completed, which I don't need new firmware for, but I am happy to maintain and help others.

Hey @btrepp .. I am willing/interested to take this crate over and migrate it over to https://github.com/rust-midi/

I have a PR #11 up here that integrates the shared midi type/conversion code that @mendelt and I have been collaborating on and also have a re-org/simplification staged that I believe addresses the concerns of the previous #10 draft request. If you want to take a look at #11 I'd be happy for that but if you're just wanting to hand off the project I'd fork it over to rust-midi (and ideally get crates.io access for usbd-midi eventually).

@btrepp
Copy link
Collaborator

btrepp commented Dec 1, 2022

I've had a look at #11 and am happy with it, just have a suggestion for the breaking change aspect and it's good to go.

I'm happy for it to be moved into rust-midi. It's logical to sit inside a broader ecosystem, and will make it easier to use and align the types.

I've added you as a collaborator to this repo to help facilitate this.

@x37v
Copy link
Collaborator Author

x37v commented Dec 12, 2022

I've added you as a collaborator to this repo to help facilitate this.

Hey @btrepp .. I'm not 100% sure what you intended by adding me as a collaborator. I'm not able to initiate a transfer to rust-midi myself as a collaborator, but I think I can merge etc.

I could simply fork over to rust-midi and eventually you could give me the keys to crates.io .. but there is also a notion of transferring a repo over to an organization..

@sourcebox
Copy link
Collaborator

Version 0.3.0 was just released on crates.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants