Cargo.toml: Add links = "cortex-m"
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @korken89 (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
|
Since this will only work for other |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 24, 2019
140: Cargo.toml: Add `links = "cortex-m"` r=therealprof a=jonas-schievink This prevents linking multiple versions of `cortex-m` together, which would be unsound. Currently it uses a `#[no_mangle]` static for this, which isn't always reliable. Fixes #137 Co-authored-by: Jonas Schievink <[email protected]>
Build failed |
|
This might be rust-lang/rust#60050? |
|
@therealprof can you give this another go? The CI failure should've gone away. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 6, 2019
140: Cargo.toml: Add `links = "cortex-m"` r=therealprof a=jonas-schievink This prevents linking multiple versions of `cortex-m` together, which would be unsound. Currently it uses a `#[no_mangle]` static for this, which isn't always reliable. Fixes #137 Co-authored-by: Jonas Schievink <[email protected]>
Build succeeded |
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
140: entry/exception/interrupt: improvements to the `static mut` transformation r=therealprof a=japaric see individual commits for details Co-authored-by: Jorge Aparicio <[email protected]>
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
after #140 landed the entry, exception and interrupt attributes started accepting code like this: ``` rust #[entry] fn main() -> ! { static mut FOO: u32 = 0; static mut FOO: i32 = 0; } ``` because that code expands into: ``` rust fn main() -> ! { let FOO: &'static mut u32 = unsafe { static mut FOO: u32 = 0; &mut FOO }; // shadows previous variable let FOO: &'static mut u32 = unsafe { static mut FOO: i32 = 0; &mut FOO }; } ``` this commit adds a check that rejects `static mut`s with duplicated names to these three attributes.
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
149: reject duplicate `static mut` variables r=therealprof a=japaric after #140 landed the entry, exception and interrupt attributes started accepting code like this: ``` rust #[entry] fn main() -> ! { static mut FOO: u32 = 0; static mut FOO: i32 = 0; } ``` because that code expands into: ``` rust fn main() -> ! { let FOO: &'static mut u32 = unsafe { static mut FOO: u32 = 0; &mut FOO }; // shadows previous variable let FOO: &'static mut u32 = unsafe { static mut FOO: i32 = 0; &mut FOO }; } ``` this commit adds a check that rejects `static mut`s with duplicated names to these three attributes. Co-authored-by: Jorge Aparicio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents linking multiple versions of
cortex-mtogether, which would beunsound. Currently it uses a
#[no_mangle]static for this, which isn't alwaysreliable.
Fixes #137