Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the Allocator trait from the unstable allocator_api #61

Merged
merged 10 commits into from
Oct 29, 2023

Conversation

rmja
Copy link
Contributor

@rmja rmja commented Feb 8, 2023

No description provided.

@rmja rmja requested a review from a team as a code owner February 8, 2023 10:38
@adamgreig
Copy link
Member

Thanks for the PR! I'll check over the Allocator part in more detail later, but in the meantime, could you change the rust-toolchain file to the newer rust-toolchain.toml format please? Details are here.

@rmja
Copy link
Contributor Author

rmja commented Feb 13, 2023

@adamgreig I changed the format.

@jannic
Copy link
Member

jannic commented Mar 21, 2023

Would that mean that CI needs to revert to nightly, undoing #66?

@adamgreig
Copy link
Member

The rust-toolchain file is from before we swapped to stable, so I think it would suffice to just add a new test case to the CI that uses nightly and enables the new feature, but still generally build and test everything else on stable.

@rmja
Copy link
Contributor Author

rmja commented May 19, 2023

@adamgreig is there something I can do to make some progress on getting this merged? :-)

@rmja rmja requested a review from a team as a code owner October 21, 2023 09:20
@rmja
Copy link
Contributor Author

rmja commented Oct 21, 2023

@adamgreig I added the allocator_api feature as part of CI. Let me know if there is anything more here that I can do.

@newAM newAM mentioned this pull request Oct 27, 2023
@newAM newAM mentioned this pull request Oct 29, 2023
Copy link
Member

@newAM newAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull-request!

I'll try to get a release out today / tomorrow.

@newAM newAM added this pull request to the merge queue Oct 29, 2023
Merged via the queue into rust-embedded:master with commit e37e935 Oct 29, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants