Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge cron.yml with ci.yml #84

Merged
merged 1 commit into from
Nov 12, 2023
Merged

merge cron.yml with ci.yml #84

merged 1 commit into from
Nov 12, 2023

Conversation

newAM
Copy link
Member

@newAM newAM commented Nov 4, 2023

Merges cron-ci.yml and ci.yml to keep cron-ci.yml up-to-date.


"Fixes" #83

This should only fail with new stabilized clippy lints or stabilized nightly features, but that has never happened.

This has only ever failed when it wasn't updated (#47, #83), or during network failures (#51)

@newAM newAM requested a review from a team as a code owner November 4, 2023 17:56
@adamgreig
Copy link
Member

I don't understand what caused the failure this week that wasn't caught by the normal PR CI? In principle this cron CI is to catch either a dependency or rust itself making a change that then only gets noticed when the next PR is opened, but if it's only flagging false positives I guess it's not justifying itself...

@newAM
Copy link
Member Author

newAM commented Nov 4, 2023

The cron-ci is compiling all examples on stable, and some examples now need nightly for the allocator_api feature, but the cron-ci wasn't updated when that was changed.

Alternatively I think(?) this could be folded into the main CI, with an if trigger == schedule condition to post an issue upon failure, then it would get updated with the main CI.

@adamgreig
Copy link
Member

Ah, got it. Yea, if it's simple to have the main CI also run on schedule and only post a new issue on failure, maybe that's worth doing just in case something does start failing with one of the nightly features.

@newAM newAM changed the title rm cron CI merge cron-ci.yml with ci.yml Nov 4, 2023
@newAM newAM linked an issue Nov 4, 2023 that may be closed by this pull request
@newAM newAM changed the title merge cron-ci.yml with ci.yml merge cron.yml with ci.yml Nov 4, 2023
@newAM
Copy link
Member Author

newAM commented Nov 4, 2023

I think this should work:

      - uses: imjohnbo/issue-bot@v3
        if: |
          failure()
          && github.event_name == 'schedule'

I guess we will find out next week 😄

@newAM newAM requested a review from Dirbaio November 11, 2023 15:37
@Dirbaio Dirbaio added this pull request to the merge queue Nov 12, 2023
Merged via the queue into master with commit 1faa839 Nov 12, 2023
8 checks passed
@Dirbaio Dirbaio deleted the rm-cron-ci branch November 12, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Failure
3 participants